-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update restart files of application tests for p4est 2.3.6 #1181
Merged
+2,844
−2,648
Merged
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
7e6f707
Update restart files in cfd-dem
acdaigneault fccba1d
Remove useless dem restart in cmake file
acdaigneault fc0755b
Update the lethe-fluid-vans restart files
acdaigneault cca24f4
Update poiseuille restart files
acdaigneault 5fff0c3
Add a restart file generator for sharp
acdaigneault 256a151
Update lethe-particles tests
acdaigneault 69c2c16
Change log
acdaigneault 1b4a5d0
Indent
acdaigneault 7f7c874
Attempt to unable test with deal.ii v9.5
acdaigneault 6a58c6c
Fix typo
acdaigneault 739152b
Use yaml ifs
acdaigneault 502c4b8
Change dp in dem generator of restart fluidized bed file
acdaigneault 3660833
Change position of initial particles in some test
acdaigneault fdfc87f
Remove the statistics
acdaigneault File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading status checks…
Use yaml ifs
commit 739152b40c19e68f18cf4baf03581fd2641d1d9d
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -63,34 +63,32 @@ jobs: | |
make -j${{ env.COMPILE_JOBS }} | ||
# These tests require a single core each so we will run them in parallel | ||
# Only run tests on deal.ii master version | ||
# Restart files are not compatible with deal.ii v9.5.0 | ||
- name: Run Lethe tests (Release-deal.ii:${{ matrix.dealii_version }}) | ||
if: ${{ matrix.dealii_version == 'master'}} | ||
run: | | ||
# Only run tests on deal.ii master version | ||
# Restart files are not compatible with deal.ii v9.5.0 | ||
if [[ ${{ matrix.dealii_version }} = "master" ]]; then | ||
#Allow OMPI to run as root | ||
export OMPI_ALLOW_RUN_AS_ROOT=1 | ||
export OMPI_ALLOW_RUN_AS_ROOT_CONFIRM=1 | ||
cd build-release | ||
# Print the tests to be executed | ||
ctest -N --exclude-regex ${{ env.MULTI_CORE_TESTS_REGEX }} | ||
# Run in parallel | ||
ctest --output-on-failure -j${{ env.COMPILE_JOBS }} --exclude-regex ${{ env.MULTI_CORE_TESTS_REGEX }} | ||
fi | ||
#Allow OMPI to run as root | ||
export OMPI_ALLOW_RUN_AS_ROOT=1 | ||
export OMPI_ALLOW_RUN_AS_ROOT_CONFIRM=1 | ||
cd build-release | ||
# Print the tests to be executed | ||
ctest -N --exclude-regex ${{ env.MULTI_CORE_TESTS_REGEX }} | ||
# Run in parallel | ||
ctest --output-on-failure -j${{ env.COMPILE_JOBS }} --exclude-regex ${{ env.MULTI_CORE_TESTS_REGEX }} | ||
# These tests require two cores each so we will run them sequencially | ||
# Only run tests on deal.ii master version | ||
# Restart files are not compatible with deal.ii v9.5.0 | ||
- name: Run multi-core Lethe tests (Release-deal.ii:${{ matrix.dealii_version }}) | ||
if: ${{ matrix.dealii_version == 'master'}} | ||
run: | | ||
# Only run tests on deal.ii master version | ||
# Restart files are not compatible with deal.ii v9.5.0 | ||
if [[ ${{ matrix.dealii_version }} = "master" ]]; then | ||
#Allow OMPI to run as root | ||
export OMPI_ALLOW_RUN_AS_ROOT=1 | ||
export OMPI_ALLOW_RUN_AS_ROOT_CONFIRM=1 | ||
cd build-release | ||
# Print the tests to be executed | ||
ctest -N --tests-regex ${{ env.MULTI_CORE_TESTS_REGEX }} | ||
# Run sequencially | ||
ctest --output-on-failure --tests-regex ${{ env.MULTI_CORE_TESTS_REGEX }} | ||
fi | ||
#Allow OMPI to run as root | ||
export OMPI_ALLOW_RUN_AS_ROOT=1 | ||
export OMPI_ALLOW_RUN_AS_ROOT_CONFIRM=1 | ||
cd build-release | ||
# Print the tests to be executed | ||
ctest -N --tests-regex ${{ env.MULTI_CORE_TESTS_REGEX }} | ||
# Run sequencially | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would add the same else error as the previous comment here. |
||
ctest --output-on-failure --tests-regex ${{ env.MULTI_CORE_TESTS_REGEX }} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add an error when matrix.dealii_version != 'master' for clarity.
Something like:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a cool suggestion.... as long as that does not throw an error I am down for that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a documentation of the else statement and error? I don't find it in the GitHub action documentation.
Also, giving an error won't failed the check?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it gives an error it would indeed fail the check.
To keep the PR finalized because it's a critical one, let's postpone this check to a next PR. We can open an issue ot keep track of this idea, but to be honest, right now just writing a comment is all good for the time being. Throwing an error would break the CI and so code: 1 would most likely give an error.
Let's postpone that for the future
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I don't change anything at the moment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, let's not change anything. Let's merge the PR as-is when you are ready with the current feature set. Then if we want to change other stuff, let's make small PRs for them