Cfd dem restart again #1158
Merged
Cfd dem restart again #1158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M-Badri
pushed a commit
to M-Badri/lethe
that referenced
this pull request
Sep 29, 2024
Description of the problem Simulations restart would not work adequately when the boundary conditions were time dependent because the local_evaluation_point was used to set up the initial conditions. Description of the solution Fix this by using the present solution to fix the local evaluation point before evaluating it. How is this tested? Added a test for this. Former-commit-id: 4d47b00
blaisb
added a commit
that referenced
this pull request
Sep 30, 2024
Description of the problem Simulations restart would not work adequately when the boundary conditions were time dependent because the local_evaluation_point was used to set up the initial conditions. Description of the solution Fix this by using the present solution to fix the local evaluation point before evaluating it. How is this tested? Added a test for this. Former-commit-id: 4d47b00
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the problem
Description of the solution
How is this tested?
Presently adding a test right now --- Done
Comments