Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove useless initial conditions application #1148

Merged
merged 3 commits into from
May 20, 2024
Merged

Remove useless initial conditions application #1148

merged 3 commits into from
May 20, 2024

Conversation

blaisb
Copy link
Contributor

@blaisb blaisb commented May 20, 2024

Description of the problem

  • The initial conditions executable is never used and is not documented. It is a remnant of how Lethe used to work in the past. It is time to remove it.

Description of the solution

  • Remove it and associated test

@blaisb blaisb requested review from voferreira and OGaboriault May 20, 2024 13:45
voferreira
voferreira approved these changes May 20, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
OGaboriault
OGaboriault approved these changes May 20, 2024
View reviewed changes
Copy link
Collaborator

@OGaboriault OGaboriault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never used this solver. I guest that if it wasn't begin used, we shouldn't keep.

This will make Lethe compile faster! :)

@blaisb @voferreira
Update CHANGELOG.md
86bf568 
Co-authored-by: Victor Oliveira Ferreira <[email protected]>
@blaisb blaisb merged commit 1c38f76 into master May 20, 2024
8 checks passed
@blaisb blaisb deleted the remove_initial_conditions branch May 20, 2024 20:12
M-Badri pushed a commit to M-Badri/lethe that referenced this pull request Sep 29, 2024
@blaisb @voferreira
Remove useless initial conditions application (chaos-polymtl#1148)
56dbcdd 
Description of the problem
The initial conditions executable is never used and is not documented. It is a remnant of how Lethe used to work in the past. It is time to remove it.
Description of the solution
Remove it and associated test

Co-authored-by: Victor Oliveira Ferreira <[email protected]>
Former-commit-id: 1c38f76
blaisb added a commit that referenced this pull request Sep 30, 2024
@blaisb @voferreira
Remove useless initial conditions application (#1148)
dd6e34a 
Description of the problem
The initial conditions executable is never used and is not documented. It is a remnant of how Lethe used to work in the past. It is time to remove it.
Description of the solution
Remove it and associated test

Co-authored-by: Victor Oliveira Ferreira <[email protected]>
Former-commit-id: 1c38f76
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OGaboriault OGaboriault OGaboriault approved these changes

@voferreira voferreira voferreira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blaisb @voferreira @OGaboriault