Adding a custom parsed function #1143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oguevremont
force-pushed
the
reactive_auxiliary_physics
branch
2 times, most recently
from
a94e69f to
0903ca2
Compare
oguevremont
force-pushed
the
reactive_auxiliary_physics
branch
from
87d32f8 to
e9a5bff
Compare
blaisb
requested changes
May 17, 2024
oguevremont
force-pushed
the
reactive_auxiliary_physics
branch
from
48a35de to
c4534a7
Compare
oguevremont
force-pushed
the
reactive_auxiliary_physics
branch
from
c4534a7 to
c2df53b
Compare
blaisb
added
the
Needs more reviewers
lpsaavedra
approved these changes
May 22, 2024
hepap
approved these changes
May 22, 2024
Co-authored-by: hepap <[email protected]>
oguevremont
removed
the
Needs more reviewers
M-Badri
pushed a commit
to M-Badri/lethe
that referenced
this pull request
Sep 29, 2024
Description of the problem In the idea of adding a reactive physics, a way to parse functions based on any variables needed to be added. For example, when a species A reacts at a rate of -dA/dt = k*A, the source term for A depends on A itself. Parsed functions in deal.II didn't allow to parse functions unless they depended only on x,y,z,t. Description of the solution A new custom class based on the deal.II implementation of parsed functions (using muParser) is added to Lethe. This class has the template parameter n_component. It requires that classes are instantiated with n_component expressions as well. Physics that will use this class will have the responsibility of interfacing between their variables of interest and the class ParsedFunctionCustom itself. When a different number of variables/expressions will be needed by a solver, this solver will have the responsibility of introducing dummy variables or expressions. This solution might change if required. How Has This Been Tested? [core/custom_parsed_functions] Unit test of value and gradient functions. Documentation Not at the moment, except for doxygen. Future changes A reactive auxiliary physics will be implemented using this class. Co-authored-by: Bruno Blais <[email protected]> Co-authored-by: hepap <[email protected]> Former-commit-id: 8b0aab5
blaisb
added a commit
that referenced
this pull request
Sep 30, 2024
Description of the problem In the idea of adding a reactive physics, a way to parse functions based on any variables needed to be added. For example, when a species A reacts at a rate of -dA/dt = k*A, the source term for A depends on A itself. Parsed functions in deal.II didn't allow to parse functions unless they depended only on x,y,z,t. Description of the solution A new custom class based on the deal.II implementation of parsed functions (using muParser) is added to Lethe. This class has the template parameter n_component. It requires that classes are instantiated with n_component expressions as well. Physics that will use this class will have the responsibility of interfacing between their variables of interest and the class ParsedFunctionCustom itself. When a different number of variables/expressions will be needed by a solver, this solver will have the responsibility of introducing dummy variables or expressions. This solution might change if required. How Has This Been Tested? [core/custom_parsed_functions] Unit test of value and gradient functions. Documentation Not at the moment, except for doxygen. Future changes A reactive auxiliary physics will be implemented using this class. Co-authored-by: Bruno Blais <[email protected]> Co-authored-by: hepap <[email protected]> Former-commit-id: 8b0aab5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the problem
Description of the solution
n_component. It requires that classes are instantiated withn_componentexpressions as well.How Has This Been Tested?
Documentation
Future changes