Rename source term NS subsection #1130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lpsaavedra I think it's a good idea to change the name, but the physics name used elsewhere for the fluid dynamics is "fluid dynamics" and not navier-stokes. I think it would be a better idea to used fluid dynamics because this source term is also used in the VANS equations for example |
lpsaavedra
force-pushed
the
rename_source_term_sec
branch
from
53a7d7b to
60b0220
Compare
|
@blaisb that makes a lot of sense. I have now updated the name of the section to fluid dynamics. I also found some parts in the documentation (multiphysics examples only) were the "enable" parameter was mentioned in the source term section. However, this parameter was deleted a while ago, so I have corrected that as well. |
blaisb
approved these changes
May 12, 2024
M-Badri
pushed a commit
to M-Badri/lethe
that referenced
this pull request
Sep 29, 2024
Description of the problem The subsection's name to specify the source term of the Navier-Stokes equations in the parameter file was set to be xyz. Description of the solution The subsection was renamed to fluid dynamics, since there are source terms for other physics where the subsection has the physics name, for example, subsection heat transfer. The change had to be made in all the parameter files of the examples, the tests and the documentation. Former-commit-id: 3ea1d11
blaisb
pushed a commit
that referenced
this pull request
Sep 30, 2024
Description of the problem The subsection's name to specify the source term of the Navier-Stokes equations in the parameter file was set to be xyz. Description of the solution The subsection was renamed to fluid dynamics, since there are source terms for other physics where the subsection has the physics name, for example, subsection heat transfer. The change had to be made in all the parameter files of the examples, the tests and the documentation. Former-commit-id: 3ea1d11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the problem
The subsection's name to specify the source term of the Navier-Stokes equations in the parameter file was set to be
xyz.Description of the solution
The subsection was renamed to
navier stokes, since there are source terms for other physics where the subsection has the physics name, for example,subsection heat transfer. The change had to be made in all the parameter files of the examples, the tests and the documentation.