-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add output time interval #1120
Merged
Merged
Add output time interval #1120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blaisb
requested changes
May 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very minor comments
Can you add a CHANGELOG entry?
Thanks :)!
oguevremont
reviewed
May 7, 2024
mivaia
commented
May 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your comments! All of them have been adressed :)
mivaia
added
Reviewed and ready to merge
and removed
Reviewed and waiting for changes
labels
May 8, 2024
oguevremont
approved these changes
May 8, 2024
blaisb
approved these changes
May 8, 2024
M-Badri
pushed a commit
to M-Badri/lethe
that referenced
this pull request
Sep 29, 2024
Description of the problem Only needed the last 30% of my simulations and they are quite heavy. Description of the solution Added a new parameter in the parameter file -> output_time_interval. If the user specifies an output time interval, the .vtu files are only written if the simulation time is within that time window. This has been implemented for output control = iteration and output control = time. How Has This Been Tested? new simulation_control_06.cc test. Makes sure information is written at the appropriated time steps. Documentation Modified the simulation_control.rst file to consider the new parameter. Former-commit-id: e4530ec
blaisb
pushed a commit
that referenced
this pull request
Sep 30, 2024
Description of the problem Only needed the last 30% of my simulations and they are quite heavy. Description of the solution Added a new parameter in the parameter file -> output_time_interval. If the user specifies an output time interval, the .vtu files are only written if the simulation time is within that time window. This has been implemented for output control = iteration and output control = time. How Has This Been Tested? new simulation_control_06.cc test. Makes sure information is written at the appropriated time steps. Documentation Modified the simulation_control.rst file to consider the new parameter. Former-commit-id: e4530ec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the problem
Description of the solution
How Has This Been Tested?
Documentation