Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add output time interval #1120

Merged
merged 6 commits into from
May 8, 2024
Merged

Add output time interval #1120

merged 6 commits into from
May 8, 2024

Conversation

mivaia
Copy link
Collaborator

@mivaia mivaia commented May 7, 2024

Description of the problem

  • Only needed the last 30% of my simulations and they are quite heavy.

Description of the solution

  • Added a new parameter in the parameter file -> output_time_interval. If the user specifies an output time interval, the .vtu files are only written if the simulation time is within that time window. This has been implemented for output control = iteration and output control = time.

How Has This Been Tested?

  • new simulation_control_06.cc test. Makes sure information is written at the appropriated time steps.

Documentation

  • Modified the simulation_control.rst file to consider the new parameter.

Copy link
Contributor

@blaisb blaisb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor comments
Can you add a CHANGELOG entry?
Thanks :)!

doc/source/parameters/cfd/simulation_control.rst Outdated Show resolved Hide resolved
tests/core/simulation_control_06.cc Outdated Show resolved Hide resolved
tests/core/simulation_control_06.cc Outdated Show resolved Hide resolved
Copy link
Collaborator Author

@mivaia mivaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your comments! All of them have been adressed :)

@blaisb blaisb merged commit e4530ec into master May 8, 2024
8 checks passed
@blaisb blaisb deleted the add_output_time_interval branch May 8, 2024 22:31
M-Badri pushed a commit to M-Badri/lethe that referenced this pull request Sep 29, 2024
Description of the problem
Only needed the last 30% of my simulations and they are quite heavy.

Description of the solution
Added a new parameter in the parameter file -> output_time_interval. If the user specifies an output time interval, the .vtu files are only written if the simulation time is within that time window. This has been implemented for output control = iteration and output control = time.

How Has This Been Tested?
new simulation_control_06.cc test. Makes sure information is written at the appropriated time steps.

Documentation
Modified the simulation_control.rst file to consider the new parameter.

Former-commit-id: e4530ec
blaisb pushed a commit that referenced this pull request Sep 30, 2024
Description of the problem
Only needed the last 30% of my simulations and they are quite heavy.

Description of the solution
Added a new parameter in the parameter file -> output_time_interval. If the user specifies an output time interval, the .vtu files are only written if the simulation time is within that time window. This has been implemented for output control = iteration and output control = time.

How Has This Been Tested?
new simulation_control_06.cc test. Makes sure information is written at the appropriated time steps.

Documentation
Modified the simulation_control.rst file to consider the new parameter.

Former-commit-id: e4530ec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants