DEM, CFD-DEM periodic boundary fix #1110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blaisb
approved these changes
May 2, 2024
Comment on lines
+1245
to
+1247
| // NOTE This first vector should not be initialized this big. | ||
| outlet_boundaries.reserve(DEM_BC_number); | ||
| bc_types.reserve(DEM_BC_number); |
There was a problem hiding this comment.
Yeah but how big is DEM_BC_number? Here it is reserved and not initialized btw, so this is not really a big deal...
There was a problem hiding this comment.
You are right, DEM_BC_number is really small
|
@OGaboriault I think this needs a CHANGELOG entry |
acdaigneault
requested changes
May 2, 2024
CHANGELOG.md
Outdated
|
|
||
| ### Fixed | ||
|
|
||
| - MAJOR Periodic boundary conditions were not working if they weren't the last boundary condition being declare in the parameter file. Now, every boundary condition work in which even order they are being declared. [#1110](https://github.com/chaos-polymtl/lethe/pull/1110) |
There was a problem hiding this comment.
Specify that this is related the periodic boundaries for DEM only
|
|
||
| subsection boundary condition 0 | ||
| subsection boundary condition 0 | ||
| # Choices are fixed_wall|outlet|rotational|translational|periodic |
There was a problem hiding this comment.
What is fixed_wall actually?
Also, maybe (in another pr) we should have a test also for rotational/translational and PBC (like a rotating drum with PBC on flat walls) and make sure all PB match well.
acdaigneault
approved these changes
May 2, 2024
acdaigneault
reviewed
May 2, 2024
OGaboriault
changed the title
yashuuzi
pushed a commit
that referenced
this pull request
May 6, 2024
Description of the problem Periodic boundary conditions were not working when they were not declare as the last BC in the parameter file. BC_type was changing value at every BC being parsed. "BC_type" was being checked later in the code (in dem.cc) to set "has_periodic_boundaries" to true or false. If the periodic BC was being declared before the an other BC, "BC_type" was not set to "BoundaryType::periodic", thus "has_periodic_boundaries = false". Description of the solution We store every BC type in a vector (BC_types). We check each component of that vector, if it's equal to "BoundaryType::periodic", then "has_periodic_boundaries = true" How Has This Been Tested? Every test is passing. I can modify one of our current test to add a dummy BC at the end of a parameter file, so that it check for this kind of problem. Comments Not gonna lie, it was not hard a bug spot in the code... wish I had spot this mistake earlier in my results....
M-Badri
pushed a commit
to M-Badri/lethe
that referenced
this pull request
Sep 29, 2024
Description of the problem Periodic boundary conditions were not working when they were not declare as the last BC in the parameter file. BC_type was changing value at every BC being parsed. "BC_type" was being checked later in the code (in dem.cc) to set "has_periodic_boundaries" to true or false. If the periodic BC was being declared before the an other BC, "BC_type" was not set to "BoundaryType::periodic", thus "has_periodic_boundaries = false". Description of the solution We store every BC type in a vector (BC_types). We check each component of that vector, if it's equal to "BoundaryType::periodic", then "has_periodic_boundaries = true" How Has This Been Tested? Every test is passing. I can modify one of our current test to add a dummy BC at the end of a parameter file, so that it check for this kind of problem. Comments Not gonna lie, it was not hard a bug spot in the code... wish I had spot this mistake earlier in my results.... Former-commit-id: 59526c4
blaisb
pushed a commit
that referenced
this pull request
Sep 30, 2024
Description of the problem Periodic boundary conditions were not working when they were not declare as the last BC in the parameter file. BC_type was changing value at every BC being parsed. "BC_type" was being checked later in the code (in dem.cc) to set "has_periodic_boundaries" to true or false. If the periodic BC was being declared before the an other BC, "BC_type" was not set to "BoundaryType::periodic", thus "has_periodic_boundaries = false". Description of the solution We store every BC type in a vector (BC_types). We check each component of that vector, if it's equal to "BoundaryType::periodic", then "has_periodic_boundaries = true" How Has This Been Tested? Every test is passing. I can modify one of our current test to add a dummy BC at the end of a parameter file, so that it check for this kind of problem. Comments Not gonna lie, it was not hard a bug spot in the code... wish I had spot this mistake earlier in my results.... Former-commit-id: 59526c4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the problem
Description of the solution
How Has This Been Tested?
Comments