Fix nitsche restart #1106
Merged
Fix nitsche restart #1106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpsaavedra
reviewed
Apr 30, 2024
|
lpsaavedra
approved these changes
Apr 30, 2024
yashuuzi
pushed a commit
that referenced
this pull request
May 6, 2024
Description of the problem Nitsche does not restart when the mesh was generated with simplices. See Nitsche model restart does not work with simplices #275 Description of the solution Fixes the issue by restarting the fully distributed triangulation for the solid correctly. How Has This Been Tested? Still pending a unit test, WIP Comments While running this test case I managed to find another bug, which is that the Nitsche model is unable of mesh adaptation once it has been restarted. This bug was there all the time. I will try to figure out something, in the meantime I will try to m erge this PR anyway. Co-authored-by: Laura Prieto Saavedra <[email protected]>
M-Badri
pushed a commit
to M-Badri/lethe
that referenced
this pull request
Sep 29, 2024
Description of the problem Nitsche does not restart when the mesh was generated with simplices. See Nitsche model restart does not work with simplices chaos-polymtl#275 Description of the solution Fixes the issue by restarting the fully distributed triangulation for the solid correctly. How Has This Been Tested? Still pending a unit test, WIP Comments While running this test case I managed to find another bug, which is that the Nitsche model is unable of mesh adaptation once it has been restarted. This bug was there all the time. I will try to figure out something, in the meantime I will try to m erge this PR anyway. Co-authored-by: Laura Prieto Saavedra <[email protected]> Former-commit-id: f96ecdd
blaisb
added a commit
that referenced
this pull request
Sep 30, 2024
Description of the problem Nitsche does not restart when the mesh was generated with simplices. See Nitsche model restart does not work with simplices #275 Description of the solution Fixes the issue by restarting the fully distributed triangulation for the solid correctly. How Has This Been Tested? Still pending a unit test, WIP Comments While running this test case I managed to find another bug, which is that the Nitsche model is unable of mesh adaptation once it has been restarted. This bug was there all the time. I will try to figure out something, in the meantime I will try to m erge this PR anyway. Co-authored-by: Laura Prieto Saavedra <[email protected]> Former-commit-id: f96ecdd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the problem
Description of the solution
How Has This Been Tested?
Comments