Correct DCDD stabilization in VOF #1103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blaisb
approved these changes
Apr 25, 2024
source/solvers/vof_assemblers.cc
Outdated
| @@ -77,7 +77,7 @@ VOFAssemblerCore<dim>::assemble_matrix(VOFScratchData<dim> &scratch_data, | |||
| Tensor<1, dim> velocity_unit_vector = | |||
| velocity / (velocity.norm() + 1e-12); | |||
| const Tensor<2, dim> k_corr = | |||
| (gradient_unit_vector * velocity_unit_vector) * | |||
| std::pow(gradient_unit_vector * velocity_unit_vector, 2) * | |||
There was a problem hiding this comment.
Can you use instead https://www.dealii.org/current/doxygen/deal.II/namespaceUtilities.html#a834c6b595ada6f8e73c78d9bbd8ec551
This way this is done at compile time since you know the power at compile time. This is always better :)
There was a problem hiding this comment.
I'll change all the ones in the file ! :)
There was a problem hiding this comment.
@blaisb It's done ! There's only the CI left ! :)
There was a problem hiding this comment.
Thanks for going the extra mile and cleaning things up
:)
source/solvers/vof_assemblers.cc
Outdated
| @@ -222,7 +222,7 @@ VOFAssemblerCore<dim>::assemble_rhs(VOFScratchData<dim> &scratch_data, | |||
| Tensor<1, dim> velocity_unit_vector = | |||
| velocity / (velocity.norm() + 1e-12); | |||
| const Tensor<2, dim> k_corr = | |||
| (gradient_unit_vector * velocity_unit_vector) * | |||
| std::pow(gradient_unit_vector * velocity_unit_vector, 2) * | |||
hepap
approved these changes
Apr 25, 2024
AmishgaAlphonius
force-pushed
the
update-vof-stabilization-in-doc
branch
from
b4a2c51 to
6fd87dd
Compare
AmishgaAlphonius
force-pushed
the
update-vof-stabilization-in-doc
branch
from
6fd87dd to
c5fb3b1
Compare
yashuuzi
pushed a commit
that referenced
this pull request
May 6, 2024
Description of the problem The DCDD VOF stabilization term taken form Tezduyar (2003) had minor a mistake in it. A square was missing. Description of the solution The missing square was added to the stabilization term. How Has This Been Tested? The following tests were updated due to the small changes in computed values : lethe-fluid/gls_droplet_marangoni_effect lethe-fluid/gls_vof_1_isothermal_compressible_fluid lethe-fluid/gls_vof_2_isothermal_compressible_fluids lethe-fluid/gls_vof_dirichlet_boundary_condition lethe-fluid/gls_vof_ht_adapt-dissipation lethe-fluid/gls_vof_hydrostat_initial_refine lethe-fluid/gls_vof_hydrostat_mesh-adapt lethe-fluid/gls_vof_periodic_boundary_condition lethe-fluid/gls_vof_static_droplet_surface_tension_force_with_tanh_filter lethe-fluid/gls_vof_tanh_filter lethe-fluid/heat_transfer_vof_phase_change_constrain_solid_domain lethe-fluid/heat_transfer_vof_weakly_compressible_flow lethe-fluid/time_dependent_boundaries_vof When tested with the rising bubble case, there seems to be no noticeable difference from before the correction. Documentation Documentation on VOF's theory was updated. doc/source/theory/multiphysics/vof.rst Comments It would be interresting to study the impact of this DCDD stabilization term and in which case it really has a great influence. Reference T. E. Tezduyar, “Computation of moving boundaries and interfaces and stabilization parameters,” Int. J. Numer. Methods Fluids, vol. 43, no. 5, pp. 555–575, 2003, doi: 10.1002/fld.505.
M-Badri
pushed a commit
to M-Badri/lethe
that referenced
this pull request
Sep 29, 2024
Description of the problem The DCDD VOF stabilization term taken form Tezduyar (2003) had minor a mistake in it. A square was missing. Description of the solution The missing square was added to the stabilization term. How Has This Been Tested? The following tests were updated due to the small changes in computed values : lethe-fluid/gls_droplet_marangoni_effect lethe-fluid/gls_vof_1_isothermal_compressible_fluid lethe-fluid/gls_vof_2_isothermal_compressible_fluids lethe-fluid/gls_vof_dirichlet_boundary_condition lethe-fluid/gls_vof_ht_adapt-dissipation lethe-fluid/gls_vof_hydrostat_initial_refine lethe-fluid/gls_vof_hydrostat_mesh-adapt lethe-fluid/gls_vof_periodic_boundary_condition lethe-fluid/gls_vof_static_droplet_surface_tension_force_with_tanh_filter lethe-fluid/gls_vof_tanh_filter lethe-fluid/heat_transfer_vof_phase_change_constrain_solid_domain lethe-fluid/heat_transfer_vof_weakly_compressible_flow lethe-fluid/time_dependent_boundaries_vof When tested with the rising bubble case, there seems to be no noticeable difference from before the correction. Documentation Documentation on VOF's theory was updated. doc/source/theory/multiphysics/vof.rst Comments It would be interresting to study the impact of this DCDD stabilization term and in which case it really has a great influence. Reference T. E. Tezduyar, “Computation of moving boundaries and interfaces and stabilization parameters,” Int. J. Numer. Methods Fluids, vol. 43, no. 5, pp. 555–575, 2003, doi: 10.1002/fld.505. Former-commit-id: c0859a0
blaisb
pushed a commit
that referenced
this pull request
Sep 30, 2024
Description of the problem The DCDD VOF stabilization term taken form Tezduyar (2003) had minor a mistake in it. A square was missing. Description of the solution The missing square was added to the stabilization term. How Has This Been Tested? The following tests were updated due to the small changes in computed values : lethe-fluid/gls_droplet_marangoni_effect lethe-fluid/gls_vof_1_isothermal_compressible_fluid lethe-fluid/gls_vof_2_isothermal_compressible_fluids lethe-fluid/gls_vof_dirichlet_boundary_condition lethe-fluid/gls_vof_ht_adapt-dissipation lethe-fluid/gls_vof_hydrostat_initial_refine lethe-fluid/gls_vof_hydrostat_mesh-adapt lethe-fluid/gls_vof_periodic_boundary_condition lethe-fluid/gls_vof_static_droplet_surface_tension_force_with_tanh_filter lethe-fluid/gls_vof_tanh_filter lethe-fluid/heat_transfer_vof_phase_change_constrain_solid_domain lethe-fluid/heat_transfer_vof_weakly_compressible_flow lethe-fluid/time_dependent_boundaries_vof When tested with the rising bubble case, there seems to be no noticeable difference from before the correction. Documentation Documentation on VOF's theory was updated. doc/source/theory/multiphysics/vof.rst Comments It would be interresting to study the impact of this DCDD stabilization term and in which case it really has a great influence. Reference T. E. Tezduyar, “Computation of moving boundaries and interfaces and stabilization parameters,” Int. J. Numer. Methods Fluids, vol. 43, no. 5, pp. 555–575, 2003, doi: 10.1002/fld.505. Former-commit-id: c0859a0
blaisb
pushed a commit
that referenced
this pull request
Nov 29, 2024
Description Updates the following example before Lethe 1.0 release: Dam-break Rayleigh-Taylor instability Capillary wave Air bubble compression Sloshing in a rectangular tank Additionally, this PR reverts the squared term in the VOF DCDD stabilization correctional direction vector (#1103) to the power 1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the problem
Description of the solution
How Has This Been Tested?
The following tests were updated due to the small changes in computed values :
lethe-fluid/gls_droplet_marangoni_effect
lethe-fluid/gls_vof_1_isothermal_compressible_fluid
lethe-fluid/gls_vof_2_isothermal_compressible_fluids
lethe-fluid/gls_vof_dirichlet_boundary_condition
lethe-fluid/gls_vof_ht_adapt-dissipation
lethe-fluid/gls_vof_hydrostat_initial_refine
lethe-fluid/gls_vof_hydrostat_mesh-adapt
lethe-fluid/gls_vof_periodic_boundary_condition
lethe-fluid/gls_vof_static_droplet_surface_tension_force_with_tanh_filter
lethe-fluid/gls_vof_tanh_filter
lethe-fluid/heat_transfer_vof_phase_change_constrain_solid_domain
lethe-fluid/heat_transfer_vof_weakly_compressible_flow
lethe-fluid/time_dependent_boundaries_vof
When tested with the rising bubble case, there seems to be no noticeable difference from before the correction.
Documentation
Documentation on VOF's theory was updated.
Comments
Reference
T. E. Tezduyar, “Computation of moving boundaries and interfaces and stabilization parameters,” Int. J. Numer. Methods Fluids, vol. 43, no. 5, pp. 555–575, 2003, doi: 10.1002/fld.505.