Pressure constraint gmg #1089
Merged
Pressure constraint gmg #1089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lpsaavedra we should merge this after your PR is merged. We just need to regenerate the output. I made it from my mac and it seems to lead to problems |
lpsaavedra
approved these changes
Apr 7, 2024
blaisb
force-pushed
the
pressure_constraint_gmg
branch
from
1fdfd07 to
eb79db0
Compare
M-Badri
pushed a commit
to M-Badri/lethe
that referenced
this pull request
Sep 29, 2024
Description of the problem When the mesh is not homogenous and the domain is closed (e.g. only dirichlet or periodic BCs), the coarse grid solver of the matrix-free GCMG or LSMG does not work. This is because the problem is ill-posed due to the pressure constant. Description of the solution On the coarse grid level, fix a pressure DOF to be zero by adding a single constraint. This ensures that the solution works. How Has This Been Tested? I changed the example to use this feature, but I also need to add an application test. Will do so in this PR. Documentation New parameter is updated and documented. Co-authored-by: Laura Prieto Saavedra <[email protected]> Former-commit-id: f824f59
blaisb
added a commit
that referenced
this pull request
Sep 30, 2024
Description of the problem When the mesh is not homogenous and the domain is closed (e.g. only dirichlet or periodic BCs), the coarse grid solver of the matrix-free GCMG or LSMG does not work. This is because the problem is ill-posed due to the pressure constant. Description of the solution On the coarse grid level, fix a pressure DOF to be zero by adding a single constraint. This ensures that the solution works. How Has This Been Tested? I changed the example to use this feature, but I also need to add an application test. Will do so in this PR. Documentation New parameter is updated and documented. Co-authored-by: Laura Prieto Saavedra <[email protected]> Former-commit-id: f824f59
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the problem
Description of the solution
How Has This Been Tested?
Documentation
Comments