Dem volume insertion initial velocities #1078
Conversation
| double vel_x = dem_parameters.insertion_info.initial_vel[0]; | ||
| double vel_y = dem_parameters.insertion_info.initial_vel[1]; | ||
| double vel_z = dem_parameters.insertion_info.initial_vel[2]; | ||
| double omega_x = dem_parameters.insertion_info.initial_ang_vel[0]; |
There was a problem hiding this comment.
I like the new parameter name, but I think I would rather keep dem_parameters.insertion_info.omega[0], because the rest of the code uses omega. Otherwise it is all clear to me :)
There was a problem hiding this comment.
Ah, and you don't need initial, since this is insertion info
There was a problem hiding this comment.
I think the initial is useful. This way, there's not confusion with the velocity at a given time step.
I can do initial_omega. I agree, omega is more coherent with the rest of code.
What do you think?
There was a problem hiding this comment.
In general, I tend to prefer long meaningful names instead of confusing abbreviations, but in this case I found it slightly redundant, hence, not necessary. This is not a strong opinion, though. So this is really up to you :)
|
Ohh shoot, did not see the comments before the merge. You can fix them in a secondary quick PR @OGaboriault |
Description of the problem This is a follow up from Victor's comment from PR [Dem volume insertion box parameters chaos-polymtl#1074 The initial velocity and initial angular velocity are now define with one parameter each. Really quick PR. No example or application test (except for one) was using those parameters. Former-commit-id: 698b063
Follow-up to PR chaos-polymtl#1078 ... Former-commit-id: 13e9dcb
Description of the problem This is a follow up from Victor's comment from PR [Dem volume insertion box parameters #1074 The initial velocity and initial angular velocity are now define with one parameter each. Really quick PR. No example or application test (except for one) was using those parameters. Former-commit-id: 698b063
Description of the problem
The initial velocity and initial angular velocity are now define with one parameter each.
Really quick PR.
No example or application test (except for one) was using those parameters.