Vof momentum monitoring #1073
Merged
Vof momentum monitoring #1073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hepap
approved these changes
Mar 19, 2024
| @@ -7,8 +7,8 @@ Running on 1 MPI rank(s)... | |||
| ---------------------- | |||
| VOF Mass Conservation | |||
| ---------------------- | |||
| time surface_fluid_0 mass_per_length_fluid_0 surface_fluid_1 mass_per_length_fluid_1 sharpening_threshold | |||
| 0.0000e+00 6.5778e-01 7.8933e-01 3.4222e-01 3.4222e+02 5.0000e-01 | |||
| time surface_fluid_0 mass_per_length_fluid_0 momentum-x_fluid_0 momentum-y_fluid_0 surface_fluid_1 mass_per_length_fluid_1 momentum-x_fluid_1 momentum-y_fluid_1 sharpening_threshold | |||
There was a problem hiding this comment.
Could it be useful to have to have the total mass and total momentum output as well?
There was a problem hiding this comment.
Someone can easily calculate those by adding the two columns in their own script. I'm not sure this is necessary :)
Co-authored-by: hepap <[email protected]>
AmishgaAlphonius
approved these changes
Mar 19, 2024
Co-authored-by: Amishga Alphonius <[email protected]>
Co-authored-by: Amishga Alphonius <[email protected]>
Co-authored-by: Amishga Alphonius <[email protected]>
Co-authored-by: Amishga Alphonius <[email protected]>
M-Badri
pushed a commit
to M-Badri/lethe
that referenced
this pull request
Sep 29, 2024
Description of the problem For some cases we are running, it is relevant to monitor both the mass and the momentum in VOF simulations Description of the solution Add momentum monitoring to the mass monitoring. I don't think it's worth it to make multiple files, instead I appended the information to the existing file. How Has This Been Tested? Tested on some of our regular benchmark and the results make sense. Documentation Updated documentation accordingly Future changes The parameter monitor mass conservation is maybe not the most appropriate right now, but I don't want to break the prm file in this PR. We could have a parameter called monitor conservation instead, of maybe monitoring mass and momentum, but i 'd rather postpone this change because it's only esthetics Co-authored-by: hepap <[email protected]> Co-authored-by: Amishga Alphonius <[email protected]> Former-commit-id: 73306f4
blaisb
added a commit
that referenced
this pull request
Sep 30, 2024
Description of the problem For some cases we are running, it is relevant to monitor both the mass and the momentum in VOF simulations Description of the solution Add momentum monitoring to the mass monitoring. I don't think it's worth it to make multiple files, instead I appended the information to the existing file. How Has This Been Tested? Tested on some of our regular benchmark and the results make sense. Documentation Updated documentation accordingly Future changes The parameter monitor mass conservation is maybe not the most appropriate right now, but I don't want to break the prm file in this PR. We could have a parameter called monitor conservation instead, of maybe monitoring mass and momentum, but i 'd rather postpone this change because it's only esthetics Co-authored-by: hepap <[email protected]> Co-authored-by: Amishga Alphonius <[email protected]> Former-commit-id: 73306f4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the problem
Description of the solution
How Has This Been Tested?
Documentation
Future changes