Implement temperature-dependant solid domain contraints in VOF #1048

AmishgaAlphonius · 2024-02-29T17:23:10Z

Description of the problem

In phase change simulations, the solid domain was treated as a simple fluid with a higher viscosity (viscous penalization). It worked quite well, but it wasn't the most efficient way to compute fluid dynamics quantities. In order to improve calculation time and linear system conditioning, homogeneous constraints are imposed on velocity DOFs in a defined solid domain through a temperature range. Additionally, pressure DOFs in the same solid domain that are not connected to fluid cells are also imposed to homogeneous constraints. The temperature range is specified through a parameter subsection, namely constrain solid domain. Previously, the implementation was done for single-fluid simulations (Temperature-dependant solid domain constraints #1038), but simulations such as laser powder bed fusion (LPBF) meltpool ones require two fluids when modelling.

Description of the solution

This PR, implements the new temperature-dependent solid domain constraints for two-phase Volume of Fluid (VOF) simulations. To select cells on which the constraints are applied, we check if the filtered phase fraction at quadrature points in the cell are within a range of accepted values. This range of accepted values is defined with the phase fraction tolerance parameter. This parameter defines an absolute tolerance on filtered phase fraction.

How Has This Been Tested?

The new feature has been tested on the Melting Cavity example by modelling to parts of the domain with different fluids while keeping the same properties in both fluids.
An application test has been added to test this feature : applications_tests/lethe-fluid/heat_transfer_vof_phase_change_constrain_solid_domain.prm (.output)

Documentation

Documentation page was updated: (doc/source/parameters/cfd/constrain_solid_domain.rst).

Comments

The structure of constrain_solid_domain() changed a bit. More functions were added to avoid code line repetitions in constrain_solid_domain_vof().
Small corrections were made in other files.

blaisb

I think this is good. I'm not sure I'm a fan of the name constrain_solid_domain because this is confusing with the regular solid domain which is not based on temperature, maybe there could be a way to have a more explicit name?

AmishgaAlphonius · 2024-03-03T03:14:00Z

I think this is good. I'm not sure I'm a fan of the name constrain_solid_domain because this is confusing with the regular solid domain which is not based on temperature, maybe there could be a way to have a more explicit name?

I agree, would constrain_solid_domain_with_temperature be too long? Or how about constrain_solid_with_temperature or constrain_domain_with_temperature?

I personally think, constrain_solid_with_temperature is good.

blaisb · 2024-03-03T16:28:04Z

I think this is good. I'm not sure I'm a fan of the name constrain_solid_domain because this is confusing with the regular solid domain which is not based on temperature, maybe there could be a way to have a more explicit name?

I agree, would constrain_solid_domain_with_temperature be too long? Or how about constrain_solid_with_temperature or constrain_domain_with_temperature?

I personally think, constrain_solid_with_temperature is good.

constrain_solid_with_temperature is good to me

hepap · 2024-03-04T13:31:17Z

Or maybe constrain_stasis @AmishgaAlphonius @blaisb ?

AmishgaAlphonius · 2024-03-04T14:02:58Z

Or maybe constrain_stasis @AmishgaAlphonius @blaisb ?

I like it! I'll rename the subsection that way and call the specific function constrain_stasis_with_temperature, so if we eventually have other constraining parameters it still works! I'll leave all other reference to solid in the other smaller functions also, since we also apply a constraint on the pressure and most are used in establish_solid_domain also.

applications_tests/lethe-fluid/heat_transfer_vof_phase_change_constrain_solid_domain.prm

doc/source/parameters/cfd/constrain_stasis.rst

include/solvers/navier_stokes_base.h

Co-authored-by: hepap <[email protected]> Co-authored-by: Bruno Blais <[email protected]>

Co-authored-by: Olivier Guévremont <[email protected]>

hepap

Here are my comments :) 2 main things of thing to check, but nice work I can't wait to use it!

hepap · 2024-03-04T15:56:35Z

applications_tests/lethe-fluid/heat_transfer_vof_phase_change_constrain_solid_domain.output

+Pressure drop: -0.366978 Pa
+Total pressure drop: -0.366978 Pa
+
+---------------
+VOF Barycenter
+---------------
+  time    x_vof    y_vof    vx_vof    vy_vof   
+0.100000 0.125000 0.058681 -0.000009 -0.000023 


Maybe you can add also the average velocity? I think the test is still good, but maybe velocity could be a good metric too.

I tried it before, but the average velocity doesn't print anything .-.

applications_tests/lethe-fluid/heat_transfer_vof_phase_change_constrain_solid_domain.prm

doc/source/parameters/cfd/constrain_stasis.rst

include/solvers/navier_stokes_base.h

include/solvers/simulation_parameters.h

source/solvers/navier_stokes_base.cc

Co-authored-by: hepap <[email protected]>

#1072) Description of the problem The recently implemented vof stasis constraint (Implement temperature-dependant solid domain contraints in VOF #1048) was not compatible with adaptive mesh refinements and checkpointing system. When refining the mesh or when restarting a simulation, the filtered phase fraction was reinitialized, but not filled with the appropriate values. Description of the solution The apply_phase_filter() function was added to post_mesh_adaptation() and read_checkpoint() functions. How Has This Been Tested? The stasis constraint was tested using the 2D LPBF benchmark : with restart and mesh adaptation; without restart and with mesh adaptation, and; with restart and without mesh adaptation.

…-polymtl#1048) Description of the problem In phase change simulations, the solid domain was treated as a simple fluid with a higher viscosity (viscous penalization). It worked quite well, but it wasn't the most efficient way to compute fluid dynamics quantities. In order to improve calculation time and linear system conditioning, homogeneous constraints are imposed on velocity DOFs in a defined solid domain through a temperature range. Additionally, pressure DOFs in the same solid domain that are not connected to fluid cells are also imposed to homogeneous constraints. The temperature range is specified through a parameter subsection, namely constrain solid domain. Previously, the implementation was done for single-fluid simulations (Temperature-dependant solid domain constraints chaos-polymtl#1038), but simulations such as laser powder bed fusion (LPBF) meltpool ones require two fluids when modelling. Description of the solution This PR, implements the new temperature-dependent solid domain constraints for two-phase Volume of Fluid (VOF) simulations. To select cells on which the constraints are applied, we check if the filtered phase fraction at quadrature points in the cell are within a range of accepted values. This range of accepted values is defined with the phase fraction tolerance parameter. This parameter defines an absolute tolerance on filtered phase fraction. How Has This Been Tested? The new feature has been tested on the Melting Cavity example by modelling to parts of the domain with different fluids while keeping the same properties in both fluids. An application test has been added to test this feature : applications_tests/lethe-fluid/heat_transfer_vof_phase_change_constrain_solid_domain.prm (.output) Documentation Documentation page was updated: (doc/source/parameters/cfd/constrain_solid_domain.rst). Comments The structure of constrain_solid_domain() changed a bit. More functions were added to avoid code line repetitions in constrain_solid_domain_vof(). Small corrections were made in other files. Co-authored-by: hepap <[email protected]> Co-authored-by: Bruno Blais <[email protected]> Co-authored-by: Olivier Guévremont <[email protected]> Former-commit-id: 581ad84

chaos-polymtl#1072) Description of the problem The recently implemented vof stasis constraint (Implement temperature-dependant solid domain contraints in VOF chaos-polymtl#1048) was not compatible with adaptive mesh refinements and checkpointing system. When refining the mesh or when restarting a simulation, the filtered phase fraction was reinitialized, but not filled with the appropriate values. Description of the solution The apply_phase_filter() function was added to post_mesh_adaptation() and read_checkpoint() functions. How Has This Been Tested? The stasis constraint was tested using the 2D LPBF benchmark : with restart and mesh adaptation; without restart and with mesh adaptation, and; with restart and without mesh adaptation. Former-commit-id: bb7cea3

Description of the problem In phase change simulations, the solid domain was treated as a simple fluid with a higher viscosity (viscous penalization). It worked quite well, but it wasn't the most efficient way to compute fluid dynamics quantities. In order to improve calculation time and linear system conditioning, homogeneous constraints are imposed on velocity DOFs in a defined solid domain through a temperature range. Additionally, pressure DOFs in the same solid domain that are not connected to fluid cells are also imposed to homogeneous constraints. The temperature range is specified through a parameter subsection, namely constrain solid domain. Previously, the implementation was done for single-fluid simulations (Temperature-dependant solid domain constraints #1038), but simulations such as laser powder bed fusion (LPBF) meltpool ones require two fluids when modelling. Description of the solution This PR, implements the new temperature-dependent solid domain constraints for two-phase Volume of Fluid (VOF) simulations. To select cells on which the constraints are applied, we check if the filtered phase fraction at quadrature points in the cell are within a range of accepted values. This range of accepted values is defined with the phase fraction tolerance parameter. This parameter defines an absolute tolerance on filtered phase fraction. How Has This Been Tested? The new feature has been tested on the Melting Cavity example by modelling to parts of the domain with different fluids while keeping the same properties in both fluids. An application test has been added to test this feature : applications_tests/lethe-fluid/heat_transfer_vof_phase_change_constrain_solid_domain.prm (.output) Documentation Documentation page was updated: (doc/source/parameters/cfd/constrain_solid_domain.rst). Comments The structure of constrain_solid_domain() changed a bit. More functions were added to avoid code line repetitions in constrain_solid_domain_vof(). Small corrections were made in other files. Co-authored-by: hepap <[email protected]> Co-authored-by: Bruno Blais <[email protected]> Co-authored-by: Olivier Guévremont <[email protected]> Former-commit-id: 581ad84

#1072) Description of the problem The recently implemented vof stasis constraint (Implement temperature-dependant solid domain contraints in VOF #1048) was not compatible with adaptive mesh refinements and checkpointing system. When refining the mesh or when restarting a simulation, the filtered phase fraction was reinitialized, but not filled with the appropriate values. Description of the solution The apply_phase_filter() function was added to post_mesh_adaptation() and read_checkpoint() functions. How Has This Been Tested? The stasis constraint was tested using the 2D LPBF benchmark : with restart and mesh adaptation; without restart and with mesh adaptation, and; with restart and without mesh adaptation. Former-commit-id: bb7cea3

AmishgaAlphonius requested review from blaisb and hepap February 29, 2024 17:23

AmishgaAlphonius self-assigned this Feb 29, 2024

AmishgaAlphonius requested a review from oguevremont February 29, 2024 18:04

AmishgaAlphonius added Enhancement New feature or request Ready for review labels Feb 29, 2024

blaisb approved these changes Mar 3, 2024

View reviewed changes

AmishgaAlphonius force-pushed the solid-velocity-constraint-vof branch 2 times, most recently from ab44eac to 93daac0 Compare March 4, 2024 14:42

oguevremont reviewed Mar 4, 2024

View reviewed changes

applications_tests/lethe-fluid/heat_transfer_vof_phase_change_constrain_solid_domain.prm Show resolved Hide resolved

doc/source/parameters/cfd/constrain_stasis.rst Outdated Show resolved Hide resolved

include/solvers/navier_stokes_base.h Outdated Show resolved Hide resolved

oguevremont approved these changes Mar 4, 2024

View reviewed changes

AmishgaAlphonius and others added 4 commits March 4, 2024 10:10

Implement temperature-dependant solid domain contraints in VOF

450fd58

Correct typos

107c55d

Rename subsection and function

69b8ecb

Co-authored-by: hepap <[email protected]> Co-authored-by: Bruno Blais <[email protected]>

Apply suggestions from code review

6f0317c

Co-authored-by: Olivier Guévremont <[email protected]>

AmishgaAlphonius force-pushed the solid-velocity-constraint-vof branch from 2b7b172 to 6f0317c Compare March 4, 2024 15:22

hepap reviewed Mar 4, 2024

View reviewed changes

Apply suggestions from code review

5e96906

Co-authored-by: hepap <[email protected]>

AmishgaAlphonius requested a review from hepap March 4, 2024 19:11

hepap approved these changes Mar 4, 2024

View reviewed changes

AmishgaAlphonius added Reviewed and ready to merge and removed Ready for review labels Mar 4, 2024

blaisb merged commit 581ad84 into master Mar 5, 2024
8 checks passed

blaisb deleted the solid-velocity-constraint-vof branch March 5, 2024 15:16

AmishgaAlphonius mentioned this pull request Mar 16, 2024

Make stasis constraint compatible with restart and adaptive mesh refi… #1072

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement temperature-dependant solid domain contraints in VOF #1048

Implement temperature-dependant solid domain contraints in VOF #1048

AmishgaAlphonius commented Feb 29, 2024 •

edited

Loading

blaisb left a comment

AmishgaAlphonius commented Mar 3, 2024

blaisb commented Mar 3, 2024

hepap commented Mar 4, 2024

AmishgaAlphonius commented Mar 4, 2024 •

edited

Loading

hepap left a comment

hepap Mar 4, 2024

AmishgaAlphonius Mar 4, 2024

Implement temperature-dependant solid domain contraints in VOF #1048

Implement temperature-dependant solid domain contraints in VOF #1048

Conversation

AmishgaAlphonius commented Feb 29, 2024 • edited Loading

Description of the problem

Description of the solution

How Has This Been Tested?

Documentation

Comments

blaisb left a comment

Choose a reason for hiding this comment

AmishgaAlphonius commented Mar 3, 2024

blaisb commented Mar 3, 2024

hepap commented Mar 4, 2024

AmishgaAlphonius commented Mar 4, 2024 • edited Loading

hepap left a comment

Choose a reason for hiding this comment

hepap Mar 4, 2024

Choose a reason for hiding this comment

AmishgaAlphonius Mar 4, 2024

Choose a reason for hiding this comment

AmishgaAlphonius commented Feb 29, 2024 •

edited

Loading

AmishgaAlphonius commented Mar 4, 2024 •

edited

Loading