Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the way floating wall are described #1360

Open
blaisb opened this issue Nov 13, 2024 · 0 comments
Open

Refactor the way floating wall are described #1360

blaisb opened this issue Nov 13, 2024 · 0 comments

Comments

@blaisb
Copy link
Contributor

blaisb commented Nov 13, 2024

The current floating wall implementation uses the following notation to specify floating walls:

subsection floating walls
set number of floating walls = 1
subsection wall 0
subsection point on wall
set x = 0
set y = 0
set z = 0
end
subsection normal vector
set nx = 0
set ny = 0
set nz = 1
end
set start time = 0
set end time = 4
end
end

My main gripe with this nomenclature is that we have moved away from using x, y , z as different variables to instead use lists of points (e.g. the point on the wall would be point on wall = 0, 0, 0) instead of using different variables. This is something that we should refactor in the short term.

@blaisb blaisb mentioned this issue Nov 13, 2024
13 tasks
blaisb added a commit that referenced this issue Nov 14, 2024
Description
The silo examples works just fine. I just fixed some information within the example to make it slightly easier to read and fixed some typos there and there.

Comment
Reading this example made me realize that the way we manage floating walls is kinda lame, so I have opened an issue #1360 regarding this.

Co-authored-by: Laura Prieto Saavedra <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant