Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(link): fix multi-line link text-decorations #880

Merged
merged 2 commits into from
Oct 22, 2024
Merged

fix(link): fix multi-line link text-decorations #880

merged 2 commits into from
Oct 22, 2024

Conversation

masoudmanson
Copy link
Contributor

@masoudmanson masoudmanson commented Oct 19, 2024 •
edited
Loading

Summary

Link
Github issue: #879

image

Checklist

  • Default Story in Storybook
  • LivePreview Story in Storybook
  • Test Story in Storybook
  • Tests written
  • Variables from defaultTheme.ts used wherever possible
  • If updating an existing component, depreciate flag has been used where necessary
  • Chromatic build verified by @chanzuckerberg/sds-design

@masoudmanson masoudmanson self-assigned this Oct 19, 2024
@masoudmanson masoudmanson linked an issue Oct 19, 2024 that may be closed by this pull request
Link component underline only applies on last line #879
Closed
@masoudmanson masoudmanson added Bug Something isn't working P0 Eng Ready for review This PR is ready for review labels Oct 19, 2024
@masoudmanson masoudmanson mentioned this pull request Oct 19, 2024
Closed
tihuan
tihuan approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@tihuan tihuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow the code is so much simpler! Thanks, @masoudmanson 😄 👏 🙏

clarsen-czi
clarsen-czi approved these changes Oct 21, 2024
View reviewed changes
Copy link

@clarsen-czi clarsen-czi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @masoudmanson!!

@masoudmanson masoudmanson merged commit 0f3ed1d into main Oct 22, 2024
10 checks passed
@masoudmanson masoudmanson deleted the 879-link-component-underline-only-applies-on-last-line branch October 22, 2024 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tihuan tihuan tihuan approved these changes

@clarsen-czi clarsen-czi clarsen-czi approved these changes

Assignees

@masoudmanson masoudmanson

Labels
Bug Something isn't working Eng P0 Ready for review This PR is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Link component underline only applies on last line
3 participants
@masoudmanson @tihuan @clarsen-czi