Skip to content
This repository has been archived by the owner on May 2, 2023. It is now read-only.

build esm and cjs for remix-utils #51

Closed
wants to merge 1 commit into from
Closed

build esm and cjs for remix-utils #51

wants to merge 1 commit into from

Conversation

jinlee93
Copy link
Contributor

@jinlee93 jinlee93 commented Apr 5, 2023

  • build esm and cjs for remix-utils to avoid require errors

@jinlee93 jinlee93 requested a review from ahuth April 5, 2023 19:36
@jinlee93 jinlee93 mentioned this pull request Apr 5, 2023
Merged
1 task
@andremalan
Copy link

@jinlee93 @ahuth does this mean that any library that uses EDS will need to build CJS as well?

@ahuth
Copy link
Contributor

ahuth commented Apr 6, 2023

does this mean that any library that uses EDS will need to build CJS as well?

I hope not.

Am kind of confused as to why we're getting remix-utils + EDS issues, and imma debug that some more. Hopefully we don't need to do multiple builds here.

@jinlee93
Copy link
Contributor Author

Closing since Link is no longer part of remix-utils

@jinlee93 jinlee93 closed this Apr 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ahuth ahuth Awaiting requested review from ahuth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jinlee93 @andremalan @ahuth