feat(close-button): remove close button #931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #187521: Remove CloseButton component. |
Codecov Report
@@ Coverage Diff @@
## main #931 +/- ##
==========================================
- Coverage 95.86% 95.78% -0.09%
==========================================
Files 142 140 -2
Lines 1162 1138 -24
Branches 181 173 -8
==========================================
- Hits 1114 1090 -24
Misses 47 47
Partials 1 1
Continue to review full report at Codecov.
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
size-limit report
| Path | Size |
|---|---|
| components | 71.66 KB (-1.92% 🔽) |
| styles | 4.49 KB (0%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
BREAKING CHANGE:
The
CloseButtonis kind of a snowflake because it has a hover effect for the icon button that we don't use anywhere else. I talked to Sean and we're good to remove it to make the close buttons consistent with our other icon buttons.This PR removes the component entirely. These are the PRs removing its callsites (they've been approved and merged):
Test Plan:
All the tests pass, and there's no reference to this
CloseButtonintrajectexcept for the flow types.