-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test pr to show TW utility classes working #678
Conversation
In storybook, can modify className in the story also to see utility classes working if it hasn't been purged |
@@ -52,6 +52,7 @@ const dialogArgs = { | |||
|
|||
export const Brand = Template.bind(null); | |||
Brand.args = { | |||
className: "visible md:invisible", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to show .visible
and breakpoints working even tho .visible
exists in both Bootstrap and TW
https://61313967cde49b003ae2a860-ztcppyrvmh.chromatic.com/?path=/story/banner--brand
(shrink and widen window to see banner disappear/appear)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! There's no Bootstrap in this repo though, so it wouldn't be a problem here :') we should test this in traject
, where Bootstrap is imported
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oooop right
}; | ||
|
||
export const Heading2 = Template.bind(null); | ||
Heading2.args = { | ||
size: "h2", | ||
children: "Heading 2 18/24", | ||
className: "bg-black hover:bg-white", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to show variants working
https://61313967cde49b003ae2a860-ztcppyrvmh.chromatic.com/?path=/story/heading--heading-2
@@ -15,12 +15,14 @@ export const Heading1 = Template.bind(null); | |||
Heading1.args = { | |||
size: "h1", | |||
children: "Heading 1 24/32", | |||
className: "text-right", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to show .text-
alignment working even tho existing in both Bootstrap and TW
https://61313967cde49b003ae2a860-ztcppyrvmh.chromatic.com/?path=/story/heading--heading-1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wooot thanks!
@@ -52,6 +52,7 @@ const dialogArgs = { | |||
|
|||
export const Brand = Template.bind(null); | |||
Brand.args = { | |||
className: "visible md:invisible", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! There's no Bootstrap in this repo though, so it wouldn't be a problem here :') we should test this in traject
, where Bootstrap is imported
Test pr to show utility classes working