Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test pr to show TW utility classes working #678

Closed
wants to merge 13 commits into from

Conversation

jinlee93
Copy link
Contributor

Test pr to show utility classes working

@jinlee93 jinlee93 requested a review from anniehu4 October 21, 2021 18:57
@jinlee93
Copy link
Contributor Author

jinlee93 commented Oct 21, 2021

Test pr to show utility classes working

In storybook, can modify className in the story also to see utility classes working if it hasn't been purged

@@ -52,6 +52,7 @@ const dialogArgs = {

export const Brand = Template.bind(null);
Brand.args = {
className: "visible md:invisible",
Copy link
Contributor Author

@jinlee93 jinlee93 Oct 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to show .visible and breakpoints working even tho .visible exists in both Bootstrap and TW
https://61313967cde49b003ae2a860-ztcppyrvmh.chromatic.com/?path=/story/banner--brand
(shrink and widen window to see banner disappear/appear)

Copy link
Contributor

@anniehu4 anniehu4 Oct 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! There's no Bootstrap in this repo though, so it wouldn't be a problem here :') we should test this in traject, where Bootstrap is imported

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oooop right

};

export const Heading2 = Template.bind(null);
Heading2.args = {
size: "h2",
children: "Heading 2 18/24",
className: "bg-black hover:bg-white",
Copy link
Contributor Author

@jinlee93 jinlee93 Oct 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -15,12 +15,14 @@ export const Heading1 = Template.bind(null);
Heading1.args = {
size: "h1",
children: "Heading 1 24/32",
className: "text-right",
Copy link
Contributor Author

@jinlee93 jinlee93 Oct 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to show .text- alignment working even tho existing in both Bootstrap and TW
https://61313967cde49b003ae2a860-ztcppyrvmh.chromatic.com/?path=/story/heading--heading-1

@jinlee93 jinlee93 changed the title test(tailwind): tailwind utility classes Test pr to show TW utility classes working Oct 21, 2021
Copy link
Contributor

@anniehu4 anniehu4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wooot thanks!

@@ -52,6 +52,7 @@ const dialogArgs = {

export const Brand = Template.bind(null);
Brand.args = {
className: "visible md:invisible",
Copy link
Contributor

@anniehu4 anniehu4 Oct 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! There's no Bootstrap in this repo though, so it wouldn't be a problem here :') we should test this in traject, where Bootstrap is imported

@jinlee93 jinlee93 marked this pull request as draft October 21, 2021 22:42
Base automatically changed from sc-141242 to main October 22, 2021 18:44
@jinlee93 jinlee93 closed this Oct 22, 2021
@jinlee93 jinlee93 deleted the jlee/test-TW-utility-classes branch October 22, 2021 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants