Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(TabGroup): update handling for tab item hover states #2124

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

booc0mtaco
Copy link
Contributor

Test Plan:

Update TabGroup to match latest design, and increment theme version to 2.1. In summary,

  • instead of adding a background color on hover, add in the highlight bar instead
  • preserve the current behavior for keyboard nav

see video for demo

  • Wrote/updated automated tests
  • CI tests / new tests are not applicable
  • Manually tested my changes, and here are the details:
Screen.Recording.2025-01-15.at.12.28.54.mov

@booc0mtaco booc0mtaco requested review from a team January 15, 2025 18:59
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.13%. Comparing base (ca8f551) to head (0110231).
Report is 2 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #2124   +/-   ##
=======================================
  Coverage   97.13%   97.13%           
=======================================
  Files         114      114           
  Lines        2829     2829           
  Branches      767      767           
=======================================
  Hits         2748     2748           
  Misses         77       77           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jan 15, 2025

size-limit report 📦

Path Size
components 95.47 KB (0%)
styles 29.85 KB (0%)

@booc0mtaco booc0mtaco requested a review from a team January 17, 2025 16:18
Copy link

@ajmoreno ajmoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@booc0mtaco booc0mtaco merged commit 8b6cb4e into next Jan 21, 2025
12 checks passed
@booc0mtaco booc0mtaco deleted the aholloway/EDS-1438 branch January 21, 2025 20:20
@booc0mtaco booc0mtaco mentioned this pull request Jan 21, 2025
booc0mtaco added a commit that referenced this pull request Jan 21, 2025
## [15.10.0](v15.9.0...v15.10.0) (2025-01-21)

[Storybook](https://61313967cde49b003ae2a860-ppfzyqbjud.chromatic.com/)

### Features

* **TabGroup:** update handling for tab item hover states ([#2124](#2124)) ([8b6cb4e](8b6cb4e))


### Bug Fixes

* **ToastNotification:** fix typo in prop name ([#2122](#2122)) ([8c70d28](8c70d28))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants