Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(VisualPageIndicator): introduce 1.0 component #2118

Merged
merged 2 commits into from
Dec 18, 2024
Merged

feat(VisualPageIndicator): introduce 1.0 component #2118

merged 2 commits into from
Dec 18, 2024

Conversation

booc0mtaco
Copy link
Contributor

@booc0mtaco booc0mtaco commented Dec 18, 2024 •
edited
Loading

Test Plan:

  • Wrote/updated automated tests
  • CI tests / new tests are not applicable
  • Manually tested my changes, and here are the details:

@booc0mtaco
Copy link
Contributor Author

Screen.Recording.2024-12-17.at.18.11.50.mov

@booc0mtaco booc0mtaco marked this pull request as draft December 18, 2024 00:13
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 18, 2024 •
edited
Loading

size-limit report 📦

Path Size
components 95.29 KB (+0.75% 🔺)
styles 29.85 KB (+0.62% 🔺)

@codecov Codecov
Copy link

codecov bot commented Dec 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.13%. Comparing base (032cb5d) to head (b64eb45).
Report is 1 commits behind head on next.

Additional details and impacted files 
@@            Coverage Diff             @@
##             next    #2118      +/-   ##
==========================================
+ Coverage   97.11%   97.13%   +0.01%     
==========================================
  Files         112      114       +2     
  Lines        2806     2825      +19     
  Branches      763      764       +1     
==========================================
+ Hits         2725     2744      +19     
  Misses         77       77              
  Partials        4        4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@booc0mtaco booc0mtaco marked this pull request as ready for review December 18, 2024 19:12
@booc0mtaco
feat(VisualPageIndicator): introduce 1.0 component
f00c65d 
- add in new token eds-theme-color-background-visual-page-indicator-current
- add in new token eds-theme-color-background-visual-page-indicator
- add in component VisualPageIndicator with tests/snapshots
- add in dynamic usage assertions
@booc0mtaco booc0mtaco requested a review from a team December 18, 2024 19:14
@booc0mtaco
Copy link
Contributor Author

Screen.Recording.2024-12-18.at.13.19.36.mov

Also includes the animation (when reduced motion is not enabled)

sskikne
sskikne approved these changes Dec 18, 2024
View reviewed changes
Copy link

@sskikne sskikne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@booc0mtaco booc0mtaco merged commit 3df98a3 into next Dec 18, 2024
12 checks passed
@booc0mtaco booc0mtaco deleted the aholloway/EDS-1446 branch December 18, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sskikne sskikne sskikne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@booc0mtaco @sskikne