chore: update component version metadata #2114
Conversation
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2114 +/- ##
=======================================
Coverage 97.11% 97.11%
=======================================
Files 112 112
Lines 2806 2806
Branches 763 763
=======================================
Hits 2725 2725
Misses 77 77
Partials 4 4 ☔ View full report in Codecov by Sentry. |
|
|
| ...createThemeVersion('1.0'), | ||
| ...createThemeVersion('2.0'), |
There was a problem hiding this comment.
why did theme version 1.3 and 2.1 disappear?
There was a problem hiding this comment.
Good question. The previous version markers were mixing two ideas together, so the version numbers were ambiguous.
Based on how design is defining the theme versions, we only have two 1.0 (SLP), and 2.0 (Render). This is mostly to normalize what versions show up for which components (there was no 1.3 theme version; that "1.3" was referring to the components API, hence the API version numbers still having the minors show up)
There was a problem hiding this comment.
added the above to the description, for that missing clarity!
The previous version markers were mixing two ideas together, so the version numbers were ambiguous.
Based on how design is defining the theme versions, we only have two 1.0 (SLP), and 2.0 (Render). This is mostly to normalize what versions show up for which components (there was no 1.3 theme version; that "1.3" was referring to the components API, hence the API version numbers still having the minors show up)
Test Plan: