Skip to content

fix: P in P #1999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 24, 2024
Merged

fix: P in P #1999

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
334f5f3
chore: use Node 20.11.1
ahuth Jun 24, 2024
d387172
fix: use a span instead of p for Notification subtitles
ahuth Jun 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .node-version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
20.9.0
20.11.1
2 changes: 1 addition & 1 deletion src/components/AppNotification/AppNotification.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ export const AppNotification = ({
{title}
</Text>
<Text
as="p"
as="span"
className={styles['app-notification__sub-title']}
preset="body-md"
>
Expand Down
24 changes: 12 additions & 12 deletions src/components/AppNotification/__snapshots__/AppNotification.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,11 @@ exports[`<AppNotification /> Default story renders snapshot 1`] = `
>
This is an AppNotification title
</div>
<p
<span
class="text text--body-md app-notification__sub-title"
>
Lorem ipsum dolor sit amet consectetur. At et vitae quis amet felis mollis in vitae. Eget in neque et molestie. Luctus sed id commodo volutpat. In a eu in id molestie consectetur pellentesque.
</p>
</span>
<div
class="app-notification__actions"
/>
Expand All @@ -41,11 +41,11 @@ exports[`<AppNotification /> LightColor story renders snapshot 1`] = `
>
This is an AppNotification title
</div>
<p
<span
class="text text--body-md app-notification__sub-title"
>
Lorem ipsum dolor sit amet consectetur. At et vitae quis amet felis mollis in vitae. Eget in neque et molestie. Luctus sed id commodo volutpat. In a eu in id molestie consectetur pellentesque.
</p>
</span>
<div
class="app-notification__actions"
>
Expand Down Expand Up @@ -93,11 +93,11 @@ exports[`<AppNotification /> LightWithDismissAndControls story renders snapshot
>
This is an AppNotification title
</div>
<p
<span
class="text text--body-md app-notification__sub-title"
>
Lorem ipsum dolor sit amet consectetur. At et vitae quis amet felis mollis in vitae. Eget in neque et molestie. Luctus sed id commodo volutpat. In a eu in id molestie consectetur pellentesque.
</p>
</span>
<div
class="app-notification__actions"
>
Expand Down Expand Up @@ -169,11 +169,11 @@ exports[`<AppNotification /> WithControls story renders snapshot 1`] = `
>
This is an AppNotification title
</div>
<p
<span
class="text text--body-md app-notification__sub-title"
>
Lorem ipsum dolor sit amet consectetur. At et vitae quis amet felis mollis in vitae. Eget in neque et molestie. Luctus sed id commodo volutpat. In a eu in id molestie consectetur pellentesque.
</p>
</span>
<div
class="app-notification__actions"
>
Expand Down Expand Up @@ -221,11 +221,11 @@ exports[`<AppNotification /> WithDismissAndControls story renders snapshot 1`] =
>
This is an AppNotification title
</div>
<p
<span
class="text text--body-md app-notification__sub-title"
>
Limited subtitle text
</p>
</span>
<div
class="app-notification__actions"
>
Expand Down Expand Up @@ -297,7 +297,7 @@ exports[`<AppNotification /> WithLinkInSubtitle story renders snapshot 1`] = `
>
This is an AppNotification title
</div>
<p
<span
class="text text--body-md app-notification__sub-title"
>
<span
Expand All @@ -314,7 +314,7 @@ exports[`<AppNotification /> WithLinkInSubtitle story renders snapshot 1`] = `

in.
</span>
</p>
</span>
<div
class="app-notification__actions"
/>
Expand Down
Loading