Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Radio): address component QA feedback #1986

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

booc0mtaco
Copy link
Contributor

@booc0mtaco booc0mtaco commented Jun 10, 2024

  • stop using radio icons which can now be removed
  • replace with styling using in-DOM elements (future proof for transitions)
  • better application of color tokens
  • add tests
  • update snapshots

Test Plan:

  • Wrote automated tests
  • CI tests / new tests are not applicable
  • Manually tested my changes, but I want to keep the details secret
  • Created and used an alpha publish
  • Manually tested my changes, and here are the details:

Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.31%. Comparing base (f6e280f) to head (abbb511).

Additional details and impacted files
@@                  Coverage Diff                   @@
##           v15-components-2.0    #1986      +/-   ##
======================================================
+ Coverage               96.77%   97.31%   +0.54%     
======================================================
  Files                     142      142              
  Lines                    3629     3615      -14     
  Branches                 1000      998       -2     
======================================================
+ Hits                     3512     3518       +6     
+ Misses                    114       94      -20     
  Partials                    3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- stop using radio icons which can now be removed
- replace with styling using in-DOM elements (future proof for transitions)
- better application of color tokens
- add tests
- update snapshots
@booc0mtaco booc0mtaco force-pushed the aholloway/EDS-1334 branch from 61e4cdd to abbb511 Compare June 11, 2024 00:15
@booc0mtaco booc0mtaco merged commit 03edc20 into v15-components-2.0 Jun 11, 2024
9 checks passed
@booc0mtaco booc0mtaco deleted the aholloway/EDS-1334 branch June 11, 2024 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant