Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add version tracking to storybook components #1885

Merged

Conversation

booc0mtaco
Copy link
Contributor

this updates how we badge components so we can keep the existing introduction badges, and add new "current" version badges. This will be used to track the versions of individual components between design and code.

Screenshot 2024-03-07 at 17 32 05

Test Plan:

  • Wrote automated tests
  • CI tests / new tests are not applicable
  • Manually tested my changes, but I want to keep the details secret
  • Created and used an alpha publish
  • Manually tested my changes, and here are the details:

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.87%. Comparing base (8218f3f) to head (c343c42).

Additional details and impacted files
@@                 Coverage Diff                 @@
##           v15-components-2.0    #1885   +/-   ##
===================================================
  Coverage               96.87%   96.87%           
===================================================
  Files                     106      106           
  Lines                    2111     2111           
  Branches                  546      546           
===================================================
  Hits                     2045     2045           
  Misses                     64       64           
  Partials                    2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@booc0mtaco booc0mtaco force-pushed the aholloway/x-add-component-version-badging branch from 1e578f7 to c343c42 Compare March 7, 2024 23:38
@booc0mtaco booc0mtaco requested a review from a team March 7, 2024 23:53
@booc0mtaco booc0mtaco marked this pull request as ready for review March 7, 2024 23:53
Copy link
Contributor

@ahuth ahuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🤘

@booc0mtaco booc0mtaco merged commit c331d7d into v15-components-2.0 Mar 8, 2024
8 checks passed
@booc0mtaco booc0mtaco deleted the aholloway/x-add-component-version-badging branch March 8, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants