Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Heading)!: remove deprecated props and refactor usages #1872

Merged
merged 4 commits into from
Mar 1, 2024
Merged

feat(Heading)!: remove deprecated props and refactor usages #1872

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8dbc67c
feat(Heading)!: remove deprecated props and refactor usages
booc0mtaco Mar 1, 2024
ff03d0a
fix(WireframeDemo): update Heading usages in demo
booc0mtaco Mar 1, 2024
b1c1987
test(Heading): add content to default story
booc0mtaco Mar 1, 2024
3ab76a2
fix(PageLevelBanner): fix style regression by using preset
booc0mtaco Mar 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .storybook/pages/WireframeDemo/WireframeDemo.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,8 @@ const LoggedOutPage = ({ onLogin }: { onLogin: () => void }) => (
src={PlaceholderImage}
/>
<div className="flex flex-col items-center gap-6">
<Heading size="h1">Application</Heading>
<Heading size="h2">Sign in</Heading>
<Heading as="h1">Application</Heading>
<Heading as="h2">Sign in</Heading>
<Text>Remember to use your school email to sign in:</Text>
</div>
<img
Expand Down Expand Up @@ -194,7 +194,7 @@ const WatchPage = ({ onLogout }: { onLogout: () => void }) => {
</Button>
<div>
<Text className="mb-2">Playing reflections in response to:</Text>
<Heading as="h1" size="h3">
<Heading as="h1" preset="headline-sm">
What's something in your life, big or small, that you're proud of?
Why are you proud of it?
</Heading>
Expand Down Expand Up @@ -315,7 +315,7 @@ const WatchPage = ({ onLogout }: { onLogout: () => void }) => {
<Text size="lg">M</Text>
</div>
<Link className="mb-4">
<Heading as="h2" size="h3">
<Heading as="h2" preset="headline-sm">
Mikaela
</Heading>
</Link>
Expand Down
2 changes: 1 addition & 1 deletion src/components/Accordion/Accordion.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,8 +200,8 @@ const AccordionButton = ({
{...other}
>
<Heading
as={headingAs || contextHeadingAs}
className={headingClassName}
size={headingAs || contextHeadingAs}
>
{children}
</Heading>
Expand Down
Loading
Loading