-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow typography components to specify any preset values #1794
Conversation
- support all the tier 2 and tier 3 typography tokens - mark other ways to modify type as deprecated (but kept) - add utility types to support typography types
size-limit report 📦
|
Codecov Report
@@ Coverage Diff @@
## next #1794 +/- ##
==========================================
+ Coverage 92.56% 92.57% +0.01%
==========================================
Files 147 147
Lines 2731 2735 +4
Branches 709 713 +4
==========================================
+ Hits 2528 2532 +4
Misses 202 202
Partials 1 1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
4249fd5
to
bfc4dc9
Compare
- generate simpler stories for the typography components - update corresponding snapshots - add relevant TODO comments for future review
bfc4dc9
to
fcbbddd
Compare
Before with
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<3
doing a merge commit so that we get two lines in the release notes, one for each component modified (and the docs PR doesn't increment the version on its own) |
Summary:
Components involved:
Heading
Text
Work:
Some clear benefits to this approach:
variant
prop valuesValidation steps:
preset
-based variants does not cause a visual snapshot changeTest Plan:
edu-stack
ortraject
as a sanity check if changes affect build or deploy, or are breaking, such as token changes, widely used component updates, hooks changes, and major dependency upgrades.