Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update omlet config #1792

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Conversation

booc0mtaco
Copy link
Contributor

@booc0mtaco booc0mtaco commented Oct 25, 2023

Summary:

  • add TS and TSX files to include
  • make sure exports is defined to mark the package entry point
  • confirm package analytics match expectations

Test Plan:

  • n/a (dev-only change affecting component analytics)

- add TS and TSX files to include
- make sure exports is defined to mark the package entry point
- confirm package analytics match expectations
@booc0mtaco booc0mtaco requested a review from a team October 25, 2023 18:52
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #1792 (9b5c6ab) into next (c2ecaf7) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             next    #1792      +/-   ##
==========================================
- Coverage   92.60%   92.56%   -0.04%     
==========================================
  Files         147      147              
  Lines        2731     2731              
  Branches      709      709              
==========================================
- Hits         2529     2528       -1     
- Misses        201      202       +1     
  Partials        1        1              

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@booc0mtaco
Copy link
Contributor Author

More information on config settings: https://docs.omlet.dev/cli/config-file

Before:
Screenshot 2023-10-25 at 13 55 45

After:
Screenshot 2023-10-25 at 13 54 20

@github-actions
Copy link

size-limit report 📦

Path Size
components 97.81 KB (0%)
styles 33 KB (0%)

@ghost
Copy link

ghost commented Oct 26, 2023

More information on config settings: https://docs.omlet.dev/cli/config-file

Before: Screenshot 2023-10-25 at 13 55 45

After: Screenshot 2023-10-25 at 13 54 20

Out of curiosity what is this depicting? There isn't any text labels for the bars so I'm not sure this means but more green seems good

@booc0mtaco
Copy link
Contributor Author

More information on config settings: https://docs.omlet.dev/cli/config-file
Before: Screenshot 2023-10-25 at 13 55 45
After: Screenshot 2023-10-25 at 13 54 20

Out of curiosity what is this depicting? There isn't any text labels for the bars so I'm not sure this means but more green seems good

Yah i removed the bar graph labels since those projects aren't public-facing at this time. Each graph represents "of the components in the project, how many are our core, EDS components". A few extra things to note here:

  • EDS itself (the top bar) isn't 100% EDS 🤔 (this makes sense once you consider the dependencies we use to build our components)
  • All projects will have some custom components, like those provided by frameworks like remix, custom recipes that wrap EDS components, etc.
  • "The higher the better" generally applies. another thing omlet lets us do is figure out which things people are building on their own, which may be useful for pulling into EDS itself. The UI provides a way to show only custom components in each project, or all projects

@booc0mtaco booc0mtaco merged commit 930cbf5 into next Oct 26, 2023
6 checks passed
@booc0mtaco booc0mtaco deleted the aholloway/x-update-omlet-config branch October 26, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant