Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade testing-library/react to v14 #1788

Merged
merged 2 commits into from
Oct 18, 2023

Conversation

booc0mtaco
Copy link
Contributor

@booc0mtaco booc0mtaco commented Oct 17, 2023

Summary:

re: testing-library/user-event#1104 (comment) update version of testing-library for react to latest major v14.

After validating stable tests, try removing/reducing calls to act() that might now be superfluous.

Test Plan:

  • Wrote automated tests
  • CI tests / new tests are not applicable
  • Manually tested my changes, but I want to keep the details secret
  • Manually tested my changes, and here are the details:
    • validate build with existing act() tests
    • validate build after removing some superfluous act() calls in test

@booc0mtaco booc0mtaco requested a review from a team October 17, 2023 22:38
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #1788 (afe2d56) into next (dd202d8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             next    #1788   +/-   ##
=======================================
  Coverage   92.56%   92.56%           
=======================================
  Files         147      147           
  Lines        2731     2731           
  Branches      710      709    -1     
=======================================
  Hits         2528     2528           
- Misses        187      202   +15     
+ Partials       16        1   -15     

see 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Oct 17, 2023

size-limit report 📦

Path Size
components 97.81 KB (0%)
styles 33 KB (0%)

@booc0mtaco
Copy link
Contributor Author

@ahuth was able to scrub away all of the extraneous act() calls, and it seems like the test runs might complete slightly faster than before 🤔. v14 seems to show fewer slow test runs, so we get to benefit from some improvements with less code ++

@booc0mtaco booc0mtaco merged commit a38e5d6 into next Oct 18, 2023
6 checks passed
@booc0mtaco booc0mtaco deleted the aholloway/x-update-rtl-dom branch October 18, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants