Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: remove deprecated dropdown #1657

Merged
merged 2 commits into from
Jul 26, 2023
Merged

Conversation

jinlee93
Copy link
Contributor

@jinlee93 jinlee93 commented Jun 8, 2023

@jinlee93 jinlee93 added the next-major PRs to hold until the next major version (should include codemod) label Jun 8, 2023
@jinlee93 jinlee93 requested a review from a team June 8, 2023 17:33
@github-actions
Copy link

github-actions bot commented Jun 8, 2023

size-limit report 📦

Path Size
components 96.57 KB (-6.02% 🔽)
styles 33.95 KB (-4.8% 🔽)

@booc0mtaco
Copy link
Contributor

don't forget to add ! to mark as major. This will be some great cleanup for our next major

@jinlee93 jinlee93 changed the title refactor: remove deprecated dropdown refactor!: remove deprecated dropdown Jun 8, 2023
@jeremiah-clothier
Copy link
Contributor

@jinlee93 is this a duplicate PR from some of the recent component cleanup work?

@jinlee93 jinlee93 marked this pull request as ready for review July 26, 2023 01:03
@jinlee93
Copy link
Contributor Author

jinlee93 commented Jul 26, 2023

@jinlee93 is this a duplicate PR from some of the recent component cleanup work?

It's not. This is now removing the old Dropdown component which was used in the demos, the breadcrumbs component, and the projectcard recipe, but those have been updated to use the Select or Menu components and hence this one can be removed here

@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #1657 (f491e32) into next (569481a) will decrease coverage by 0.11%.
Report is 1 commits behind head on next.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             next    #1657      +/-   ##
==========================================
- Coverage   92.58%   92.48%   -0.11%     
==========================================
  Files         155      145      -10     
  Lines        2766     2542     -224     
  Branches      725      657      -68     
==========================================
- Hits         2561     2351     -210     
+ Misses        188      175      -13     
+ Partials       17       16       -1     
Files Changed Coverage Δ
src/index.ts 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@booc0mtaco booc0mtaco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@jinlee93 jinlee93 merged commit 26d1694 into next Jul 26, 2023
@jinlee93 jinlee93 deleted the jlee/removeDeprecatedDropdown branch July 26, 2023 16:01
@booc0mtaco booc0mtaco mentioned this pull request Aug 14, 2023
booc0mtaco added a commit that referenced this pull request Aug 15, 2023
## [13.0.0](v12.4.2...v13.0.0) (2023-08-14)


### ⚠ BREAKING CHANGES

* **link:** remove text-link tokens for link t3 tokens (#1639)
* **colors:** remove old colors and convert to input and show figma token (#1711)
* remove deprecated dropdown (#1657)
* **banner:** remove component (#1702)
* remove legacy tokens and typography mixins (#1709)
* **Grid:** remove top-level sub-component(s) (#1703)
* **dragdrop:** remove top level subcomponents (#1697)
* **Fieldset:** remove top-level sub-component(s) (#1695)
* **HorizontalStepper:** remove top-level sub-component(s) (#1696)
* **Card:** remove top-level sub-component(s) (#1692)
* **checkbox:** remove top level subcomponents (#1693)
* **radio:** remove top level subcomponents (#1690)
* **DataBar:** remove top-level sub-component(s) (#1686)
* **Modal:** remove top-level sub-component(s) (#1689)
* **searchbar:** remove top level subcomponents (#1687)
* **table:** remove top-level sub-components (#1685)
* **toolbar:** remove component (#1683)
* **Breadcrumbs:** remove top-level sub-component (#1680)
* **timelinenav:** remove top-level sub-component (#1681)

### Features

* **Breadcrumbs:** remove top-level sub-component ([#1680](#1680)) ([669081d](669081d))
* **Card:** remove top-level sub-component(s) ([#1692](#1692)) ([7ec01f4](7ec01f4))
* **checkbox:** remove top level subcomponents ([#1693](#1693)) ([87b12e8](87b12e8))
* **DataBar:** remove top-level sub-component(s) ([#1686](#1686)) ([b4b9276](b4b9276))
* **dragdrop:** remove top level subcomponents ([#1697](#1697)) ([b4fd00c](b4fd00c))
* **Fieldset:** remove top-level sub-component(s) ([#1695](#1695)) ([0c8280d](0c8280d))
* **Grid:** remove top-level sub-component(s) ([#1703](#1703)) ([c8925c9](c8925c9))
* **HorizontalStepper:** remove top-level sub-component(s) ([#1696](#1696)) ([188fd99](188fd99))
* **Layout:** mark layout components as deprecated ([#1700](#1700)) ([930a369](930a369))
* **Modal:** remove top-level sub-component(s) ([#1689](#1689)) ([8743e62](8743e62))
* **radio:** remove top level subcomponents ([#1690](#1690)) ([82da617](82da617))
* remove legacy tokens and typography mixins ([#1709](#1709)) ([ec3e819](ec3e819))
* **searchbar:** remove top level subcomponents ([#1687](#1687)) ([d13bb6c](d13bb6c))
* **table:** remove top-level sub-components ([#1685](#1685)) ([742a530](742a530))
* **timelinenav:** remove top-level sub-component ([#1681](#1681)) ([f46eca7](f46eca7))


### Bug Fixes

* **Avatar:** support display names using emoji and multi-byte ([#1716](#1716)) ([1294022](1294022))
* update token exports ([#1722](#1722)) ([982c55f](982c55f))


* **banner:** remove component ([#1702](#1702)) ([356550c](356550c))
* **colors:** remove old colors and convert to input and show figma token ([#1711](#1711)) ([c9a5079](c9a5079))
* **link:** remove text-link tokens for link t3 tokens ([#1639](#1639)) ([d35cfe4](d35cfe4))
* remove deprecated dropdown ([#1657](#1657)) ([26d1694](26d1694))
* **toolbar:** remove component ([#1683](#1683)) ([bd47899](bd47899))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next-major PRs to hold until the next major version (should include codemod)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants