fix(Menu): reset menu item hover and defer to popover #1653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- reset any color set directly on the menu item line - set the state color to our text/neutral-default color
|
|
size-limit report 📦
|
Codecov Report
@@ Coverage Diff @@
## next #1653 +/- ##
=======================================
Coverage 93.29% 93.29%
=======================================
Files 222 222
Lines 2955 2955
Branches 717 717
=======================================
Hits 2757 2757
Misses 181 181
Partials 17 17 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jinlee93
approved these changes
Jun 6, 2023
Merged
booc0mtaco
added a commit
that referenced
this pull request
Jun 21, 2023
## [12.2.0](v12.1.0...v12.2.0) (2023-06-21) ### Features * deprecate color-other-eraser token ([#1640](#1640)) ([55a78e2](55a78e2)) * **Text:** add support for caption-md and caption-lg ([53fd4e0](53fd4e0)) ### Bug Fixes * allow all valid input types ([#1648](#1648)) ([e674741](e674741)) * **InputField:** fix alignment and color for required marker ([#1654](#1654)) ([1c3b1db](1c3b1db)) * make menu, popover, select ssr friendly ([#1660](#1660)) ([eac8829](eac8829)) * **Menu:** reset menu item hover and defer to popover ([#1653](#1653)) ([f329e4d](f329e4d)) * **ProgressBar:** align label and caption with design ([#1655](#1655)) ([9de0d6b](9de0d6b)) * **Tooltip:** use caption-lg for tooltip text ([f0772c7](f0772c7))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Test Plan:
a:hoverin storybook to make sure it doesn't override component text color