Skip to content

refactor(toast): deprecate component #1652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2023
Merged

refactor(toast): deprecate component #1652

merged 1 commit into from
Jun 6, 2023

Conversation

jinlee93
Copy link
Contributor

@jinlee93 jinlee93 commented Jun 6, 2023

Summary:

marks the Toast component as deprecated, an AI result of 6/6 design pairing

Test Plan:

  • Manually tested my changes, and here are the details:
    • attempting to use it has the TS warnings and strikethrough
    • deprecated tag added to stories
    • not used in other EDS components in code

@jinlee93 jinlee93 requested a review from a team June 6, 2023 17:19
@github-actions
Copy link

github-actions bot commented Jun 6, 2023

size-limit report 📦

Path Size
components 95 KB (+0.01% 🔺)
styles 36.4 KB (0%)

@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Merging #1652 (7c6e02b) into next (35dde31) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             next    #1652   +/-   ##
=======================================
  Coverage   93.29%   93.29%           
=======================================
  Files         222      222           
  Lines        2955     2955           
  Branches      717      717           
=======================================
  Hits         2757     2757           
  Misses        181      181           
  Partials       17       17           
Impacted Files Coverage Δ
src/components/Toast/Toast.tsx 92.85% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jinlee93 jinlee93 merged commit 94a11d0 into next Jun 6, 2023
@jinlee93 jinlee93 deleted the jlee/deprecateToast branch June 6, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants