Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing token updates #1608

Merged
merged 1 commit into from
May 3, 2023

Conversation

booc0mtaco
Copy link
Contributor

Summary:

  • somehow these values weren't part of any commit
  • add them in now
  • (note: all build releases run agains a build, including these changes)

Test Plan:

  • Wrote automated tests
  • CI tests / new tests are not applicable
  • Manually tested my changes, but I want to keep the details secret
  • Manually tested my changes, and here are the details:
    • Create an alpha publish and try out in edu-stack or traject as a sanity check if changes affect build or deploy, or are breaking, such as token changes, widely used component updates, hooks changes, and major dependency upgrades.

- somehow these values weren't part of any commit
- add them in now
- (note: all build releases run agains a build, including these changes)
@github-actions
Copy link

github-actions bot commented May 2, 2023

size-limit report 📦

Path Size
components 94.5 KB (0%)
styles 36.61 KB (0%)

@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

Merging #1608 (d50b994) into next (09caa92) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             next    #1608   +/-   ##
=======================================
  Coverage   91.32%   91.32%           
=======================================
  Files         280      280           
  Lines        4195     4195           
  Branches      787      787           
=======================================
  Hits         3831     3831           
  Misses        338      338           
  Partials       26       26           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@booc0mtaco
Copy link
Contributor Author

I think what happened on that other PR is that I made a known change without re-running storybook. Storybook triggers a build before running, so that will catch almost all cases of build changes.

@booc0mtaco booc0mtaco requested a review from a team May 3, 2023 15:28
@booc0mtaco
Copy link
Contributor Author

Adding a task to prevent this edge case.

@booc0mtaco booc0mtaco merged commit 734863f into next May 3, 2023
@booc0mtaco booc0mtaco deleted the aholloway/x-commit-missing-token-values branch May 3, 2023 16:48
@ahuth ahuth mentioned this pull request May 11, 2023
ahuth added a commit that referenced this pull request May 11, 2023
### [12.0.2](v12.0.1...v12.0.2) (2023-05-11)


### Bug Fixes

* add missing token updates ([#1608](#1608)) ([734863f](734863f))
* ensure [@import](https://github.com/import) rules are before any other styles ([#1611](#1611)) ([855f691](855f691))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants