Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sync typography presets to documentation #1592

Merged
merged 1 commit into from
Apr 17, 2023
Merged

Conversation

booc0mtaco
Copy link
Contributor

Summary:

  • use similar naming for weights (regular)
  • break out mobile presets from media queries
  • add missing semibold font weight token to mobile presets

Test Plan:

  • Wrote automated tests
  • CI tests / new tests are not applicable
  • Manually tested my changes, but I want to keep the details secret
  • Manually tested my changes, and here are the details:
    • update snapshots where semibold should apply

@github-actions
Copy link

github-actions bot commented Apr 12, 2023

size-limit report 📦

Path Size
components 118.9 KB (0%)
styles 3.13 KB (0%)

@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Merging #1592 (3514f07) into next (9a67e16) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             next    #1592   +/-   ##
=======================================
  Coverage   91.72%   91.72%           
=======================================
  Files         279      279           
  Lines        4292     4292           
  Branches      784      784           
=======================================
  Hits         3937     3937           
  Misses        353      353           
  Partials        2        2           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

- use similar naming for weights (regular)
- break out mobile presets from media queries
- add missing semibold font weight token to mobile presets
@booc0mtaco booc0mtaco requested a review from a team April 12, 2023 20:07
@booc0mtaco booc0mtaco merged commit b56eadb into next Apr 17, 2023
@booc0mtaco booc0mtaco deleted the aholloway/EDS-916 branch April 17, 2023 15:03
@booc0mtaco booc0mtaco mentioned this pull request Apr 17, 2023
booc0mtaco added a commit that referenced this pull request Apr 17, 2023
## [12.0.0](v11.1.1...v12.0.0) (2023-04-17)


### ⚠ BREAKING CHANGES

* use rollup (#1555)

### Features

* export some subcomponents ([#1579](#1579)) ([2857ae4](2857ae4))
* **TextareaField:** add character length counter ([#1580](#1580)) ([ff6226f](ff6226f))


### Bug Fixes

* restore check for undefined any types ([#1585](#1585)) ([c7fae07](c7fae07))
* **Skeleton:** mark .Rect as deprecated ([#1586](#1586)) ([405f81b](405f81b))
* sync typography presets to documentation ([#1592](#1592)) ([b56eadb](b56eadb))
* **typography:** add missing eds-font-size-20 ([#1591](#1591)) ([de5dd03](de5dd03))


### build

* use rollup ([#1555](#1555)) ([d794696](d794696)), closes [#1558](#1558) [#1572](#1572) [#1581](#1581) [#1582](#1582)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants