Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove unused commonjs plugin #1582

Merged
merged 4 commits into from
Apr 10, 2023
Merged

refactor: remove unused commonjs plugin #1582

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d093b15
chore(release): 12.0.0-alpha.1
Apr 4, 2023
d58182b
refactor: use named import for clsx
Apr 4, 2023
56b590d
chore: remove rollup plugin commonjs
Apr 4, 2023
3910985
Revert "refactor: use named import for clsx"
Apr 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.

## [12.0.0-alpha.1](https://github.com/chanzuckerberg/edu-design-system/compare/v12.0.0-alpha.0...v12.0.0-alpha.1) (2023-04-04)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oop alpha publish changelogs snuck in here but shouldn't matter

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked back and saw a few other older builds included alpha stuff in the change log. This shouldn't interfere with any releases, but makes the change log slightly weird

## [12.0.0-alpha.0](https://github.com/chanzuckerberg/edu-design-system/compare/v11.0.0...v12.0.0-alpha.0) (2023-04-04)


Expand Down
3 changes: 1 addition & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@chanzuckerberg/eds",
"version": "12.0.0-alpha.0",
"version": "12.0.0-alpha.1",
"description": "The React-powered design system library for Chan Zuckerberg Initiative education web applications",
"author": "CZI <[email protected]>",
"homepage": "https://github.com/chanzuckerberg/edu-design-system",
Expand Down Expand Up @@ -109,7 +109,6 @@
"@commitlint/cli": "^17.5.1",
"@commitlint/config-conventional": "^17.4.4",
"@geometricpanda/storybook-addon-badges": "^1.1.1",
"@rollup/plugin-commonjs": "^24.0.1",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused plugin, tsconfig handles for us

"@rollup/plugin-node-resolve": "^15.0.1",
"@rollup/plugin-typescript": "^11.0.0",
"@size-limit/file": "^8.2.4",
Expand Down
42 changes: 2 additions & 40 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1658,7 +1658,6 @@ __metadata:
"@geometricpanda/storybook-addon-badges": ^1.1.1
"@headlessui/react": ^1.7.13
"@popperjs/core": ^2.11.7
"@rollup/plugin-commonjs": ^24.0.1
"@rollup/plugin-node-resolve": ^15.0.1
"@rollup/plugin-typescript": ^11.0.0
"@size-limit/file": ^8.2.4
Expand Down Expand Up @@ -2619,7 +2618,7 @@ __metadata:
languageName: node
linkType: hard

"@jridgewell/sourcemap-codec@npm:1.4.14, @jridgewell/sourcemap-codec@npm:^1.4.10, @jridgewell/sourcemap-codec@npm:^1.4.13":
"@jridgewell/sourcemap-codec@npm:1.4.14, @jridgewell/sourcemap-codec@npm:^1.4.10":
version: 1.4.14
resolution: "@jridgewell/sourcemap-codec@npm:1.4.14"
checksum: 61100637b6d173d3ba786a5dff019e1a74b1f394f323c1fee337ff390239f053b87266c7a948777f4b1ee68c01a8ad0ab61e5ff4abb5a012a0b091bec391ab97
Expand Down Expand Up @@ -2840,25 +2839,6 @@ __metadata:
languageName: node
linkType: hard

"@rollup/plugin-commonjs@npm:^24.0.1":
version: 24.0.1
resolution: "@rollup/plugin-commonjs@npm:24.0.1"
dependencies:
"@rollup/pluginutils": ^5.0.1
commondir: ^1.0.1
estree-walker: ^2.0.2
glob: ^8.0.3
is-reference: 1.2.1
magic-string: ^0.27.0
peerDependencies:
rollup: ^2.68.0||^3.0.0
peerDependenciesMeta:
rollup:
optional: true
checksum: ff5b09f5c350640fe6836fcc97bf5c5612bf78b26eaaad01bf1aee955f0b136135d1a8950a02f680779aec1f16f2c6b6cf89d6080e84ed09be62737abb6b3a5f
languageName: node
linkType: hard

"@rollup/plugin-node-resolve@npm:^15.0.1":
version: 15.0.1
resolution: "@rollup/plugin-node-resolve@npm:15.0.1"
Expand Down Expand Up @@ -11457,7 +11437,7 @@ __metadata:
languageName: node
linkType: hard

"glob@npm:^8.0.1, glob@npm:^8.0.3":
"glob@npm:^8.0.1":
version: 8.1.0
resolution: "glob@npm:8.1.0"
dependencies:
Expand Down Expand Up @@ -12969,15 +12949,6 @@ __metadata:
languageName: node
linkType: hard

"is-reference@npm:1.2.1":
version: 1.2.1
resolution: "is-reference@npm:1.2.1"
dependencies:
"@types/estree": "*"
checksum: e7b48149f8abda2c10849ea51965904d6a714193d68942ad74e30522231045acf06cbfae5a4be2702fede5d232e61bf50b3183acdc056e6e3afe07fcf4f4b2bc
languageName: node
linkType: hard

"is-regex@npm:^1.1.2, is-regex@npm:^1.1.4":
version: 1.1.4
resolution: "is-regex@npm:1.1.4"
Expand Down Expand Up @@ -14831,15 +14802,6 @@ __metadata:
languageName: node
linkType: hard

"magic-string@npm:^0.27.0":
version: 0.27.0
resolution: "magic-string@npm:0.27.0"
dependencies:
"@jridgewell/sourcemap-codec": ^1.4.13
checksum: 273faaa50baadb7a2df6e442eac34ad611304fc08fe16e24fe2e472fd944bfcb73ffb50d2dc972dc04e92784222002af46868cb9698b1be181c81830fd95a13e
languageName: node
linkType: hard

"make-dir@npm:^2.0.0, make-dir@npm:^2.1.0":
version: 2.1.0
resolution: "make-dir@npm:2.1.0"
Expand Down