chore(clickable-style): make transition target more specific #1249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #205509: EDS Button focus outline cut off in Safari. |
dierat
force-pushed
the
diedra/focus/fix-transition
branch
from
64b3fcc to
d47c301
Compare
dierat
commented
Aug 29, 2022
Comment on lines
+31
to
+35
| transition: color var(--eds-anim-fade-quick) var(--eds-anim-ease); | ||
|
|
||
| @media screen and (prefers-reduced-motion) { | ||
| transition: none; | ||
| } |
There was a problem hiding this comment.
I also added a transition for svgs because I noticed we're changing the color on hover/focus but we're not animating it, which might look weird against the animating button colors.
Codecov Report
@@ Coverage Diff @@
## next #1249 +/- ##
=======================================
Coverage 91.18% 91.18%
=======================================
Files 297 297
Lines 4117 4117
Branches 749 749
=======================================
Hits 3754 3754
Misses 362 362
Partials 1 1 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
This pull request has been linked to Shortcut Story #208013: Banner focus indicators doesn't work in Safari. |
jinlee93
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Currently our buttons don't have visible focus outlines in Safari. Through process of elimination, I found that the source of the issue is the
transitionstyling. Thetransitionis targetingall, not specific CSS properties (which is considered best practice). I don't know exactly what's going on, but making the transition specific, which I was planning to do anyway at some point, fixes this.Test Plan:
Open storybook in Safari,
navigate to either the
Buttoncomponent and a component that uses it (like the dismissablePageLevelBannerstories),tab to the button with your keyboard,
and verify the focus outline is visible.
(Please note that you need to have turned on the "Press Tab to highlight each item on a webpage" accessibility setting in Safari to see this functionality.)