Skip to content

fix: optional meta in project card #1193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 19, 2022
Merged

fix: optional meta in project card #1193

merged 1 commit into from
Jul 19, 2022

Conversation

ifrost1
Copy link
Contributor

@ifrost1 ifrost1 commented Jul 18, 2022

Summary:

  • Added conditional wrapper around meta in ProjectCard to make that optional for Emma
  • Added story with this to show that this is possible

Test Plan:

yarn lint runs through
yarn test runs through
yarn types runs through
yarn start runs

@ifrost1 ifrost1 requested review from csnizik and a team July 18, 2022 14:41
csnizik
csnizik approved these changes Jul 18, 2022
View reviewed changes
Copy link
Contributor

@csnizik csnizik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does exactly what it says on the tin.

@ifrost1 ifrost1 merged commit 986ec95 into next Jul 19, 2022
@ifrost1 ifrost1 deleted the ifrost/206227-project-card-hide-meta branch July 19, 2022 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dierat dierat dierat approved these changes

@csnizik csnizik csnizik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ifrost1 @dierat @csnizik