Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Breadcrumbs)!: remove top-level sub-component #1680

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

booc0mtaco
Copy link
Contributor

Summary:

  • merge BreadcrumbsItem into Breadcrumbs directly

Test Plan:

  • Verify snapshots and chromatic doesn't change

- merge BreadcrumbsItem into Breadcrumbs directly
@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #1680 (d65f8d5) into feature/EFI-1219 (4d80a51) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@                 Coverage Diff                  @@
##           feature/EFI-1219    #1680      +/-   ##
====================================================
- Coverage             93.23%   93.21%   -0.02%     
====================================================
  Files                   222      220       -2     
  Lines                  2970     2963       -7     
  Branches                721      721              
====================================================
- Hits                   2769     2762       -7     
  Misses                  184      184              
  Partials                 17       17              
Impacted Files Coverage Δ
src/index.ts 100.00% <ø> (ø)
src/components/Breadcrumbs/Breadcrumbs.tsx 95.45% <100.00%> (+1.22%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@booc0mtaco
Copy link
Contributor Author

Note: merging into feature branch, so we can get all of these converted w/o having multiple major releases with them sprinkled in

@booc0mtaco booc0mtaco requested review from czi-developer-foundations and a team and removed request for czi-developer-foundations July 12, 2023 17:36
@booc0mtaco booc0mtaco merged commit 5647737 into feature/EFI-1219 Jul 12, 2023
@booc0mtaco booc0mtaco deleted the aholloway/EFI-1221 branch July 12, 2023 21:24
booc0mtaco added a commit that referenced this pull request Jul 19, 2023
- merge BreadcrumbsItem into Breadcrumbs directly
@booc0mtaco booc0mtaco mentioned this pull request Aug 14, 2023
booc0mtaco added a commit that referenced this pull request Aug 15, 2023
## [13.0.0](v12.4.2...v13.0.0) (2023-08-14)


### ⚠ BREAKING CHANGES

* **link:** remove text-link tokens for link t3 tokens (#1639)
* **colors:** remove old colors and convert to input and show figma token (#1711)
* remove deprecated dropdown (#1657)
* **banner:** remove component (#1702)
* remove legacy tokens and typography mixins (#1709)
* **Grid:** remove top-level sub-component(s) (#1703)
* **dragdrop:** remove top level subcomponents (#1697)
* **Fieldset:** remove top-level sub-component(s) (#1695)
* **HorizontalStepper:** remove top-level sub-component(s) (#1696)
* **Card:** remove top-level sub-component(s) (#1692)
* **checkbox:** remove top level subcomponents (#1693)
* **radio:** remove top level subcomponents (#1690)
* **DataBar:** remove top-level sub-component(s) (#1686)
* **Modal:** remove top-level sub-component(s) (#1689)
* **searchbar:** remove top level subcomponents (#1687)
* **table:** remove top-level sub-components (#1685)
* **toolbar:** remove component (#1683)
* **Breadcrumbs:** remove top-level sub-component (#1680)
* **timelinenav:** remove top-level sub-component (#1681)

### Features

* **Breadcrumbs:** remove top-level sub-component ([#1680](#1680)) ([669081d](669081d))
* **Card:** remove top-level sub-component(s) ([#1692](#1692)) ([7ec01f4](7ec01f4))
* **checkbox:** remove top level subcomponents ([#1693](#1693)) ([87b12e8](87b12e8))
* **DataBar:** remove top-level sub-component(s) ([#1686](#1686)) ([b4b9276](b4b9276))
* **dragdrop:** remove top level subcomponents ([#1697](#1697)) ([b4fd00c](b4fd00c))
* **Fieldset:** remove top-level sub-component(s) ([#1695](#1695)) ([0c8280d](0c8280d))
* **Grid:** remove top-level sub-component(s) ([#1703](#1703)) ([c8925c9](c8925c9))
* **HorizontalStepper:** remove top-level sub-component(s) ([#1696](#1696)) ([188fd99](188fd99))
* **Layout:** mark layout components as deprecated ([#1700](#1700)) ([930a369](930a369))
* **Modal:** remove top-level sub-component(s) ([#1689](#1689)) ([8743e62](8743e62))
* **radio:** remove top level subcomponents ([#1690](#1690)) ([82da617](82da617))
* remove legacy tokens and typography mixins ([#1709](#1709)) ([ec3e819](ec3e819))
* **searchbar:** remove top level subcomponents ([#1687](#1687)) ([d13bb6c](d13bb6c))
* **table:** remove top-level sub-components ([#1685](#1685)) ([742a530](742a530))
* **timelinenav:** remove top-level sub-component ([#1681](#1681)) ([f46eca7](f46eca7))


### Bug Fixes

* **Avatar:** support display names using emoji and multi-byte ([#1716](#1716)) ([1294022](1294022))
* update token exports ([#1722](#1722)) ([982c55f](982c55f))


* **banner:** remove component ([#1702](#1702)) ([356550c](356550c))
* **colors:** remove old colors and convert to input and show figma token ([#1711](#1711)) ([c9a5079](c9a5079))
* **link:** remove text-link tokens for link t3 tokens ([#1639](#1639)) ([d35cfe4](d35cfe4))
* remove deprecated dropdown ([#1657](#1657)) ([26d1694](26d1694))
* **toolbar:** remove component ([#1683](#1683)) ([bd47899](bd47899))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant