fix(Typography): update type ramp to sync with design #1601
Conversation
size-limit report 📦
|
Codecov Report
@@ Coverage Diff @@
## next #1601 +/- ##
=======================================
Coverage 91.46% 91.46%
=======================================
Files 279 279
Lines 4172 4172
Branches 784 784
=======================================
Hits 3816 3816
+ Misses 354 330 -24
- Partials 2 26 +24 see 11 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| @@ -133,7 +133,7 @@ | |||
| font-family: var(--eds-font-family-primary) $important; | |||
| font-weight: var(--eds-font-weight-medium) $important; | |||
| font-size: var(--eds-font-size-14) $important; | |||
| line-height: 1.57 $important; | |||
There was a problem hiding this comment.
This particular preset is very confused. In code, it is always 14/22. In design, it is sometimes 14/22 (14/24 for regular, and 14/22 for light and bold). In storybook it is always 14/24 (but 006-light is missing from the page). currently trying to clarify
There was a problem hiding this comment.
Fixing up to be based on 14/22 across the board
booc0mtaco
force-pushed
the
aholloway/EDS-926
branch
from
27d5475 to
bc41e81
Compare
booc0mtaco
changed the title
|
|
booc0mtaco
force-pushed
the
aholloway/EDS-926
branch
from
bc41e81 to
44c1494
Compare
|
Waiting on some feedback for the build errors. 004-light is used in a few places, but is simultaneously not defined in the type ramp |
booc0mtaco
force-pushed
the
aholloway/EDS-926
branch
2 times, most recently
from
26442b2 to
9420373
Compare
- update type ramp line heights and font sizes to be more precise - add missing values and update existing values - update documentation to reflect values in figma - remove unreferenced type ramp levels from storybook - update the names of body typography presets (remove -text) - update the names of caption typography presets (remove -text)
booc0mtaco
force-pushed
the
aholloway/EDS-926
branch
from
9420373 to
8b0a958
Compare
| @@ -41,7 +41,7 @@ | |||
| "value": "0.75rem" | |||
| }, | |||
| "11": { | |||
| "value": "0.688rem" | |||
| "value": "0.6875rem" | |||
There was a problem hiding this comment.
Adding precision so that the pixel size doesn't include any partial pixels
There was a problem hiding this comment.
Somehow, our process won't take changes like this, and generate other diffs to be committed (re: #1608)
| @@ -40,31 +40,32 @@ | |||
| @mixin eds-typography-preset-009-bold $important; | |||
| } | |||
|
|
|||
| @define-mixin eds-theme-typography-body-text-lg $important { | |||
| @define-mixin eds-theme-typography-body-lg $important { | |||
There was a problem hiding this comment.
removing -text from the mixin names to match design names in figma
There was a problem hiding this comment.
adding mappings to each weight instead of special code at the bottom. This object will come in use later to generate all the typography stuff, since there are several chunks that are duplicative
|
@jeremiah-clothier this one grew a bit in scope. lemme know if you spot anything that needs clarification here |
### [12.0.1](v12.0.0...v12.0.1) (2023-05-02) ### Bug Fixes * polyfill for useid for react <18 ([#1595](#1595)) ([4d32194](4d32194)) * restore check for undefined any types ([#1600](#1600)) ([214cd88](214cd88)) * suppress warnings from useId imports and prop usage ([#1606](#1606)) ([c875d9d](c875d9d)) * **Typography:** update type ramp to sync with design ([#1601](#1601)) ([be5b868](be5b868))
Summary:
Test Plan: