Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typography): add missing eds-font-size-20 #1591

Merged
merged 1 commit into from
Apr 11, 2023
Merged

Conversation

booc0mtaco
Copy link
Contributor

Summary:

  • this size was referenced in code, but not defined as a token or variable.
  • add it in after cross-checking with the related design
  • Verify the sizing logic (1rem = 16px/16px) for font-size 20px

Test Plan:

  • Wrote automated tests
  • CI tests / new tests are not applicable
  • Manually tested my changes, but I want to keep the details secret
  • Manually tested my changes, and here are the details:
    • verify breakpoint appears properly
    • verify the token and css variable is defined

@booc0mtaco
Copy link
Contributor Author

Screenshot 2023-04-11 at 16 24 41

Screenshot 2023-04-11 at 16 24 28

@github-actions
Copy link

size-limit report 📦

Path Size
components 118.9 KB (0%)
styles 3.13 KB (+0.16% 🔺)

@booc0mtaco booc0mtaco requested a review from a team April 11, 2023 21:26
@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Merging #1591 (d29374a) into next (fcef92f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             next    #1591   +/-   ##
=======================================
  Coverage   91.70%   91.70%           
=======================================
  Files         279      279           
  Lines        4292     4292           
  Branches      784      784           
=======================================
  Hits         3936     3936           
  Misses        354      354           
  Partials        2        2           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@jinlee93 jinlee93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird those snaps were affected but the font size changes makes sense

@booc0mtaco
Copy link
Contributor Author

@jinlee93 turns out those snaps had bugs in them 🐛. at full viewport, the percentage signs and the "/ XX" were supposed to be smaller. Those snaps were using the preset-003 which had the missing font size at that breakpoint. So this fixes that too :)

@booc0mtaco
Copy link
Contributor Author

Screenshot 2023-04-11 at 16 35 18

@booc0mtaco booc0mtaco merged commit de5dd03 into next Apr 11, 2023
@booc0mtaco booc0mtaco deleted the aholloway/EDS-887 branch April 11, 2023 21:46
@booc0mtaco booc0mtaco mentioned this pull request Apr 17, 2023
booc0mtaco added a commit that referenced this pull request Apr 17, 2023
## [12.0.0](v11.1.1...v12.0.0) (2023-04-17)


### ⚠ BREAKING CHANGES

* use rollup (#1555)

### Features

* export some subcomponents ([#1579](#1579)) ([2857ae4](2857ae4))
* **TextareaField:** add character length counter ([#1580](#1580)) ([ff6226f](ff6226f))


### Bug Fixes

* restore check for undefined any types ([#1585](#1585)) ([c7fae07](c7fae07))
* **Skeleton:** mark .Rect as deprecated ([#1586](#1586)) ([405f81b](405f81b))
* sync typography presets to documentation ([#1592](#1592)) ([b56eadb](b56eadb))
* **typography:** add missing eds-font-size-20 ([#1591](#1591)) ([de5dd03](de5dd03))


### build

* use rollup ([#1555](#1555)) ([d794696](d794696)), closes [#1558](#1558) [#1572](#1572) [#1581](#1581) [#1582](#1582)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants