-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(typography): add missing eds-font-size-20 #1591
Conversation
size-limit report 📦
|
Codecov Report
@@ Coverage Diff @@
## next #1591 +/- ##
=======================================
Coverage 91.70% 91.70%
=======================================
Files 279 279
Lines 4292 4292
Branches 784 784
=======================================
Hits 3936 3936
Misses 354 354
Partials 2 2 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weird those snaps were affected but the font size changes makes sense
@jinlee93 turns out those snaps had bugs in them 🐛. at full viewport, the percentage signs and the "/ XX" were supposed to be smaller. Those snaps were using the preset-003 which had the missing font size at that breakpoint. So this fixes that too :) |
## [12.0.0](v11.1.1...v12.0.0) (2023-04-17) ### ⚠ BREAKING CHANGES * use rollup (#1555) ### Features * export some subcomponents ([#1579](#1579)) ([2857ae4](2857ae4)) * **TextareaField:** add character length counter ([#1580](#1580)) ([ff6226f](ff6226f)) ### Bug Fixes * restore check for undefined any types ([#1585](#1585)) ([c7fae07](c7fae07)) * **Skeleton:** mark .Rect as deprecated ([#1586](#1586)) ([405f81b](405f81b)) * sync typography presets to documentation ([#1592](#1592)) ([b56eadb](b56eadb)) * **typography:** add missing eds-font-size-20 ([#1591](#1591)) ([de5dd03](de5dd03)) ### build * use rollup ([#1555](#1555)) ([d794696](d794696)), closes [#1558](#1558) [#1572](#1572) [#1581](#1581) [#1582](#1582)
Summary:
Test Plan: