fix: restore check for undefined any types #1585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
- fix up places that were relying on that rule - do this now, as a future version of TS will ignore this override and start breaking everything - also fix up some associated recipes (Filter)
booc0mtaco
force-pushed
the
aholloway/EFI-1018
branch
from
a6ec05e to
76a92b7
Compare
Codecov Report
@@ Coverage Diff @@
## next #1585 +/- ##
==========================================
- Coverage 91.70% 91.69% -0.01%
==========================================
Files 279 279
Lines 4292 4288 -4
Branches 786 784 -2
==========================================
- Hits 3936 3932 -4
- Misses 330 354 +24
+ Partials 26 2 -24
... and 11 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ghost
reviewed
Apr 5, 2023
| | 'h3' | ||
| | 'h4' | ||
| | 'h5' | ||
| | /** @deprecated */ 'h6'; |
There was a problem hiding this comment.
:o are <h6> not recommended anymore? I don't think I've ever actually used an <h6> just wondering where this is coming from?
There was a problem hiding this comment.
@jeremiah-clothier that one is a little weird... we have a runtime check to prevent its usage here but not sure why
jinlee93
approved these changes
Apr 6, 2023
booc0mtaco
commented
Apr 6, 2023
| @@ -14,7 +14,6 @@ | |||
| "resolveJsonModule": true, | |||
| "skipLibCheck": true, | |||
| "strict": true, | |||
| "suppressImplicitAnyIndexErrors": true, | |||
There was a problem hiding this comment.
(documentation) - we were mass ignoring places where any was set by TS
Similar to this: TypeStrong/ts-loader#1559
Merged
booc0mtaco
added a commit
that referenced
this pull request
Apr 17, 2023
## [12.0.0](v11.1.1...v12.0.0) (2023-04-17) ### ⚠ BREAKING CHANGES * use rollup (#1555) ### Features * export some subcomponents ([#1579](#1579)) ([2857ae4](2857ae4)) * **TextareaField:** add character length counter ([#1580](#1580)) ([ff6226f](ff6226f)) ### Bug Fixes * restore check for undefined any types ([#1585](#1585)) ([c7fae07](c7fae07)) * **Skeleton:** mark .Rect as deprecated ([#1586](#1586)) ([405f81b](405f81b)) * sync typography presets to documentation ([#1592](#1592)) ([b56eadb](b56eadb)) * **typography:** add missing eds-font-size-20 ([#1591](#1591)) ([de5dd03](de5dd03)) ### build * use rollup ([#1555](#1555)) ([d794696](d794696)), closes [#1558](#1558) [#1572](#1572) [#1581](#1581) [#1582](#1582)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Test Plan: