fix: test changing card to article tag

chanzuckerberg · Jun 10, 2022 · a0c05f4 · a0c05f4
1 parent b1dceb0
commit a0c05f4
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 24 deletions.
diff --git a/src/components/Card/Card.tsx b/src/components/Card/Card.tsx
@@ -67,9 +67,9 @@ export const Card = ({
     elevation === 'raised' && styles['card--raised'],
   );
   return (
-    <div className={componentClassName} {...other}>
+    <article className={componentClassName} {...other}>
       {children}
-    </div>
+    </article>
   );
 };
 

diff --git a/src/components/CardFooter/CardFooter.tsx b/src/components/CardFooter/CardFooter.tsx
@@ -26,8 +26,8 @@ export interface Props {
 export const CardFooter = ({ children, className, ...other }: Props) => {
   const componentClassName = clsx(styles['card__footer'], className, {});
   return (
-    <div className={componentClassName} {...other}>
+    <footer className={componentClassName} {...other}>
       {children}
-    </div>
+    </footer>
   );
 };
diff --git a/src/components/DragDrop/__snapshots__/DragDrop.test.tsx.snap b/src/components/DragDrop/__snapshots__/DragDrop.test.tsx.snap
@@ -62,15 +62,15 @@ exports[`<DragDrop /> Default story renders snapshot 1`] = `
                 />
               </svg>
             </div>
-            <div
+            <article
               class="card example-card card--raised"
             >
               <div
                 class="card__body"
               >
                 Card 1
               </div>
-            </div>
+            </article>
           </li>
           <li
             class="drag-drop__item"
@@ -101,15 +101,15 @@ exports[`<DragDrop /> Default story renders snapshot 1`] = `
                 />
               </svg>
             </div>
-            <div
+            <article
               class="card example-card card--raised"
             >
               <div
                 class="card__body"
               >
                 Card 2
               </div>
-            </div>
+            </article>
           </li>
           <li
             class="drag-drop__item"
@@ -140,15 +140,15 @@ exports[`<DragDrop /> Default story renders snapshot 1`] = `
                 />
               </svg>
             </div>
-            <div
+            <article
               class="card example-card card--raised"
             >
               <div
                 class="card__body"
               >
                 Card 3
               </div>
-            </div>
+            </article>
           </li>
           <li
             class="drag-drop__item"
@@ -179,15 +179,15 @@ exports[`<DragDrop /> Default story renders snapshot 1`] = `
                 />
               </svg>
             </div>
-            <div
+            <article
               class="card example-card card--raised"
             >
               <div
                 class="card__body"
               >
                 Card 4
               </div>
-            </div>
+            </article>
           </li>
           <li
             class="drag-drop__item"
@@ -218,15 +218,15 @@ exports[`<DragDrop /> Default story renders snapshot 1`] = `
                 />
               </svg>
             </div>
-            <div
+            <article
               class="card example-card card--raised"
             >
               <div
                 class="card__body"
               >
                 Card 5
               </div>
-            </div>
+            </article>
           </li>
         </ol>
       </div>
@@ -455,15 +455,15 @@ exports[`<DragDrop /> HoveredHandle story renders snapshot 1`] = `
                 />
               </svg>
             </div>
-            <div
+            <article
               class="card example-card card--raised"
             >
               <div
                 class="card__body"
               >
                 Card 1
               </div>
-            </div>
+            </article>
           </li>
           <li
             class="drag-drop__item drag-drop__item--hover"
@@ -494,15 +494,15 @@ exports[`<DragDrop /> HoveredHandle story renders snapshot 1`] = `
                 />
               </svg>
             </div>
-            <div
+            <article
               class="card example-card card--raised"
             >
               <div
                 class="card__body"
               >
                 Card 2
               </div>
-            </div>
+            </article>
           </li>
           <li
             class="drag-drop__item drag-drop__item--hover"
@@ -533,15 +533,15 @@ exports[`<DragDrop /> HoveredHandle story renders snapshot 1`] = `
                 />
               </svg>
             </div>
-            <div
+            <article
               class="card example-card card--raised"
             >
               <div
                 class="card__body"
               >
                 Card 3
               </div>
-            </div>
+            </article>
           </li>
           <li
             class="drag-drop__item drag-drop__item--hover"
@@ -572,15 +572,15 @@ exports[`<DragDrop /> HoveredHandle story renders snapshot 1`] = `
                 />
               </svg>
             </div>
-            <div
+            <article
               class="card example-card card--raised"
             >
               <div
                 class="card__body"
               >
                 Card 4
               </div>
-            </div>
+            </article>
           </li>
           <li
             class="drag-drop__item drag-drop__item--hover"
@@ -611,15 +611,15 @@ exports[`<DragDrop /> HoveredHandle story renders snapshot 1`] = `
                 />
               </svg>
             </div>
-            <div
+            <article
               class="card example-card card--raised"
             >
               <div
                 class="card__body"
               >
                 Card 5
               </div>
-            </div>
+            </article>
           </li>
         </ol>
       </div>