Skip to content

Commit

Permalink
fix: lint fix. remove console logs
Browse files Browse the repository at this point in the history
  • Loading branch information
@ifrost1
ifrost1 committed Jun 13, 2022
1 parent 18140e9 commit 8adc40e
Show file tree
Hide file tree
Showing 4 changed files with 41 additions and 32 deletions.
52 changes: 26 additions & 26 deletions .storybook/pages/Cad/Cad.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -404,10 +404,6 @@ export const Cad = () => {
children: (
<ProjectCard
behavior="draggable"
meta="12 days"
number={1}
numberAriaLabel="Project 1"
title="Longer project card title that wraps"
buttonDropdownItems={
<>
<DropdownMenuItem>
Expand Down Expand Up @@ -444,6 +440,10 @@ export const Cad = () => {
</DropdownMenuItem>
</>
}
meta="12 days"
number={1}
numberAriaLabel="Project 1"
title="Longer project card title that wraps"
></ProjectCard>
),
},
Expand All @@ -452,10 +452,6 @@ export const Cad = () => {
children: (
<ProjectCard
behavior="draggable"
meta="12 days"
number={indexState}
numberAriaLabel="Project 2"
title="Project card title"
buttonDropdownItems={
<>
<DropdownMenuItem>
Expand Down Expand Up @@ -492,6 +488,10 @@ export const Cad = () => {
</DropdownMenuItem>
</>
}
meta="12 days"
number={indexState}
numberAriaLabel="Project 2"
title="Project card title"
></ProjectCard>
),
},
Expand All @@ -500,10 +500,6 @@ export const Cad = () => {
children: (
<ProjectCard
behavior="draggable"
meta="12 days"
number={3}
numberAriaLabel="Project 3"
title="Project card title"
buttonDropdownItems={
<>
<DropdownMenuItem>
Expand Down Expand Up @@ -540,6 +536,10 @@ export const Cad = () => {
</DropdownMenuItem>
</>
}
meta="12 days"
number={3}
numberAriaLabel="Project 3"
title="Project card title"
></ProjectCard>
),
},
Expand All @@ -548,10 +548,6 @@ export const Cad = () => {
children: (
<ProjectCard
behavior="draggable"
meta="12 days"
number={4}
numberAriaLabel="Project 4"
title="Project card title"
buttonDropdownItems={
<>
<DropdownMenuItem>
Expand Down Expand Up @@ -588,6 +584,10 @@ export const Cad = () => {
</DropdownMenuItem>
</>
}
meta="12 days"
number={4}
numberAriaLabel="Project 4"
title="Project card title"
></ProjectCard>
),
},
Expand All @@ -596,11 +596,6 @@ export const Cad = () => {
children: (
<ProjectCard
behavior="draggable"
buttonDropdownPosition="top-left"
meta="12 days"
number={5}
numberAriaLabel="Project 5"
title="Project card title"
buttonDropdownItems={
<>
<DropdownMenuItem>
Expand Down Expand Up @@ -637,6 +632,11 @@ export const Cad = () => {
</DropdownMenuItem>
</>
}
buttonDropdownPosition="top-left"
meta="12 days"
number={5}
numberAriaLabel="Project 5"
title="Project card title"
></ProjectCard>
),
},
Expand All @@ -645,11 +645,6 @@ export const Cad = () => {
children: (
<ProjectCard
behavior="draggable"
buttonDropdownPosition="top-left"
meta="12 days"
number={6}
numberAriaLabel="Project 6"
title="Project card title"
buttonDropdownItems={
<>
<DropdownMenuItem>
Expand Down Expand Up @@ -686,6 +681,11 @@ export const Cad = () => {
</DropdownMenuItem>
</>
}
buttonDropdownPosition="top-left"
meta="12 days"
number={6}
numberAriaLabel="Project 6"
title="Project card title"
></ProjectCard>
),
},
Expand Down
10 changes: 10 additions & 0 deletions src/components/DragDrop/__snapshots__/DragDrop.test.tsx.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ exports[`<DragDrop /> Default story renders snapshot 1`] = `
</div>
<article
class="card example-card card--raised"
number="1"
>
<div
class="card__body"
Expand Down Expand Up @@ -103,6 +104,7 @@ exports[`<DragDrop /> Default story renders snapshot 1`] = `
</div>
<article
class="card example-card card--raised"
number="2"
>
<div
class="card__body"
Expand Down Expand Up @@ -142,6 +144,7 @@ exports[`<DragDrop /> Default story renders snapshot 1`] = `
</div>
<article
class="card example-card card--raised"
number="3"
>
<div
class="card__body"
Expand Down Expand Up @@ -181,6 +184,7 @@ exports[`<DragDrop /> Default story renders snapshot 1`] = `
</div>
<article
class="card example-card card--raised"
number="4"
>
<div
class="card__body"
Expand Down Expand Up @@ -220,6 +224,7 @@ exports[`<DragDrop /> Default story renders snapshot 1`] = `
</div>
<article
class="card example-card card--raised"
number="5"
>
<div
class="card__body"
Expand Down Expand Up @@ -457,6 +462,7 @@ exports[`<DragDrop /> HoveredHandle story renders snapshot 1`] = `
</div>
<article
class="card example-card card--raised"
number="1"
>
<div
class="card__body"
Expand Down Expand Up @@ -496,6 +502,7 @@ exports[`<DragDrop /> HoveredHandle story renders snapshot 1`] = `
</div>
<article
class="card example-card card--raised"
number="2"
>
<div
class="card__body"
Expand Down Expand Up @@ -535,6 +542,7 @@ exports[`<DragDrop /> HoveredHandle story renders snapshot 1`] = `
</div>
<article
class="card example-card card--raised"
number="3"
>
<div
class="card__body"
Expand Down Expand Up @@ -574,6 +582,7 @@ exports[`<DragDrop /> HoveredHandle story renders snapshot 1`] = `
</div>
<article
class="card example-card card--raised"
number="4"
>
<div
class="card__body"
Expand Down Expand Up @@ -613,6 +622,7 @@ exports[`<DragDrop /> HoveredHandle story renders snapshot 1`] = `
</div>
<article
class="card example-card card--raised"
number="5"
>
<div
class="card__body"
Expand Down
3 changes: 1 addition & 2 deletions src/components/DropdownMenu/DropdownMenu.tsx
View file
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
import clsx from 'clsx';
import React, { ReactNode, useRef, useEffect, KeyboardEvent } from 'react';
import styles from './DropdownMenu.module.css';
import { isReactFragment } from '../../util/isReactFragment';
import {
L_ARROW_KEYCODE,
U_ARROW_KEYCODE,
R_ARROW_KEYCODE,
D_ARROW_KEYCODE,
ESCAPE_KEYCODE,
} from '../../util/keycodes';
import { isReactFragment } from '../../util/isReactFragment';

export interface Props {
/**
Expand Down Expand Up @@ -113,7 +113,6 @@ export const DropdownMenu: React.FC<Props> = ({
const newChildren = child.props.children;
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
return newChildren.map((item: ReactNode, i: number) => {
console.log(item);
// @ts-expect-error TODO: fix "No overload matches this call" error
return React.cloneElement<Props>(item, {
ref: (el: HTMLLIElement) => (childRefs.current[i] = el) /* 1 */,
Expand Down
8 changes: 4 additions & 4 deletions src/components/ProjectCard/ProjectCard.stories.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -15,19 +15,19 @@ const Template: Story<Props> = (args) => (
{...args}
buttonDropdownItems={
<>
<DropdownMenuItem onClick={() => console.log('Item 1')}>
<DropdownMenuItem>
<Icon name="schedule" purpose="decorative" size="1.25rem" />
Move to other section
</DropdownMenuItem>
<DropdownMenuItem onClick={() => console.log('Item 2')}>
<DropdownMenuItem>
<Icon name="schedule" purpose="decorative" size="1.25rem" />
Move up
</DropdownMenuItem>
<DropdownMenuItem onClick={() => console.log('Item 3')}>
<DropdownMenuItem>
<Icon name="schedule" purpose="decorative" size="1.25rem" />
Move down
</DropdownMenuItem>
<DropdownMenuItem onClick={() => console.log('Item 4')}>
<DropdownMenuItem>
<Icon name="schedule" purpose="decorative" size="1.25rem" />
Move view details
</DropdownMenuItem>
Expand Down

0 comments on commit 8adc40e

Please sign in to comment.