feat: allow <Button> to take a data-testid prop

chanzuckerberg · Jul 26, 2021 · 2256f72 · 2256f72
1 parent e191aa9
commit 2256f72
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/packages/components/src/Button/button.stories.tsx b/packages/components/src/Button/button.stories.tsx
@@ -15,9 +15,7 @@ export default {
   },
 };
 
-type Args = React.ComponentProps<typeof Button> & {
-  "data-testid"?: string;
-};
+type Args = React.ComponentProps<typeof Button>;
 
 const Template: Story<Args> = (args) => <Button {...args} />;
 

diff --git a/packages/components/src/Button/button.tsx b/packages/components/src/Button/button.tsx
@@ -10,6 +10,7 @@ export type ButtonProps = ButtonHTMLElementProps & {
    */
   children: ReactNode;
   color?: ClickableProps<"button">["color"];
+  "data-testid"?: string;
   size?: ClickableProps<"button">["size"];
   variant?: ClickableProps<"button">["variant"];
 };