Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert nextclade tag to a parse-able date #1702

Merged
merged 2 commits into from
Aug 19, 2024
Merged

Conversation

jgadling
Copy link
Contributor

@jgadling jgadling commented Aug 19, 2024

Convert nextclade's version tag back to a parse-able date.

Summary:

Demos:

Notes:

Checklist:

  • I merged latest <base branch>
  • I manually verified the change
  • I added labels to my PR
  • I tested in multiple browsers
  • I added relevant unit tests
  • I have notified others of changes they need to make locally (migrations, jobs, package updates, etc)

@jgadling jgadling requested a review from danrlu August 19, 2024 15:12
@jgadling jgadling changed the title Nextclade uses an invalid date string for tags. This converts the tag Convert nextclade tag to a parse-able date Aug 19, 2024
Copy link
Collaborator

@danrlu danrlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I'll check in staging.

@danrlu danrlu merged commit c7ea6a9 into trunk Aug 19, 2024
14 checks passed
@danrlu danrlu deleted the jgadling/fix-date-tag branch August 19, 2024 16:30
@danrlu
Copy link
Collaborator

danrlu commented Aug 19, 2024

This looks good!
image

thanhleviet pushed a commit to theiagenghi/theiagenepi that referenced this pull request Sep 12, 2024
* Nextclade uses an invalid date string for tags. This converts the tag
back to a parseable date.

* update tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants