Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make sure mpox trees exclude invalid samples #1700

Merged
merged 1 commit into from
Aug 16, 2024
Merged

fix: make sure mpox trees exclude invalid samples #1700

merged 1 commit into from
Aug 16, 2024

Conversation

jgadling
Copy link
Contributor

Summary:

  • What: Download the latest excluded samples every time we build an mpox tree
  • Ticket:

Demos:

Notes:

Checklist:

  • I merged latest <base branch>
  • I manually verified the change
  • I added labels to my PR
  • I tested in multiple browsers
  • I added relevant unit tests
  • I have notified others of changes they need to make locally (migrations, jobs, package updates, etc)

@jgadling jgadling added bug Something isn't working backend Involves changes to backend code labels Aug 16, 2024
danrlu
danrlu approved these changes Aug 16, 2024
View reviewed changes
Copy link
Collaborator

@danrlu danrlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I can test it once in staging~~~

@jgadling jgadling merged commit dec5228 into trunk Aug 16, 2024
19 checks passed
@jgadling jgadling deleted the jgadling/mpox-exclusions-update branch August 16, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danrlu danrlu danrlu approved these changes

@phoenixAja phoenixAja Awaiting requested review from phoenixAja

Assignees
No one assigned
Labels
backend Involves changes to backend code bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jgadling @danrlu