Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix unit tests #2562

Merged
merged 1 commit into from
Aug 25, 2022
Merged

chore: fix unit tests #2562

merged 1 commit into from
Aug 25, 2022

Conversation

atarashansky
Copy link
Contributor

@atarashansky atarashansky commented Aug 25, 2022

Changes

  • modified jsonify_strict to explicitly use the StrictJSONEncoder and updated the jsonify_strict test.

@atarashansky atarashansky changed the title fix unit tests chore: fix unit tests Aug 25, 2022
@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Merging #2562 (6870bc8) into main (a9044b0) will increase coverage by 71.60%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##           main    #2562       +/-   ##
=========================================
+ Coverage      0   71.60%   +71.60%     
=========================================
  Files         0       96       +96     
  Lines         0     6652     +6652     
  Branches      0      770      +770     
=========================================
+ Hits          0     4763     +4763     
- Misses        0     1813     +1813     
- Partials      0       76       +76     
Flag Coverage Δ
frontend 71.60% <100.00%> (?)
javascript 71.60% <100.00%> (?)
unitTest 71.60% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/common/utils/utils.py 78.26% <100.00%> (ø)
client/src/globals.js 92.72% <0.00%> (ø)
client/src/annoMatrix/schema.js 77.27% <0.00%> (ø)
client/src/annoMatrix/loader.js 83.22% <0.00%> (ø)
client/src/util/promiseLimit.js 100.00% <0.00%> (ø)
client/src/annoMatrix/crossfilter.js 89.78% <0.00%> (ø)
client/src/util/stateManager/schemaHelpers.js 72.41% <0.00%> (ø)
...ent/__tests__/util/annoMatrix/serverMocks/index.js 100.00% <0.00%> (ø)
server/common/annotations/local_file_csv.py 51.41% <0.00%> (ø)
server/common/config/server_config.py 86.06% <0.00%> (ø)
... and 87 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ashin-czi
Copy link
Contributor

LGTM! Strange error but glad you were able to figure it out because I was pretty stumped 🤔

Thanks!

@atarashansky atarashansky merged commit ff5da77 into main Aug 25, 2022
@atarashansky atarashansky deleted the atar/fix-unit-tests branch August 25, 2022 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants