Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add PR Linting #2560

Merged
merged 3 commits into from
Oct 24, 2022
Merged

feat: Add PR Linting #2560

merged 3 commits into from
Oct 24, 2022

Conversation

seve
Copy link
Contributor

@seve seve commented Aug 23, 2022

Copying changes made in data portal + hosted cellxgene repos to desktop.

More info:
chanzuckerberg/single-cell-data-portal#1150

Adding the most recent contributors to this repo as revewiers.

@seve seve enabled auto-merge (squash) August 23, 2022 17:09
@seve seve disabled auto-merge August 23, 2022 17:09
@seve seve enabled auto-merge (squash) August 23, 2022 17:09
Copy link
Contributor

@atolopko-czi atolopko-czi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but note amannn/action-semantic-pull-request is up to v5

@atolopko-czi atolopko-czi self-requested a review October 18, 2022 18:54
@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Merging #2560 (fd55f0a) into main (54ab9d7) will not change coverage.
The diff coverage is n/a.

❗ Current head fd55f0a differs from pull request most recent head 7705fc7. Consider uploading reports for the commit 7705fc7 to get more accurate results

@@           Coverage Diff           @@
##             main    #2560   +/-   ##
=======================================
  Coverage   71.59%   71.59%           
=======================================
  Files          96       96           
  Lines        6650     6650           
  Branches      770      770           
=======================================
  Hits         4761     4761           
  Misses       1813     1813           
  Partials       76       76           
Flag Coverage Δ
frontend 71.59% <ø> (ø)
javascript 71.59% <ø> (ø)
unitTest 71.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@seve seve merged commit 127de34 into main Oct 24, 2022
@seve seve deleted the seve/conventional-commit branch October 24, 2022 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants