Fix float16 support [#2379] #2483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert to float32 on startup unless backed, in which case error. scipy does not support complex slicing from float16 data so this is the easiest fix for now.
Codecov Report
@@ Coverage Diff @@
## main #2483 +/- ##
==========================================
+ Coverage 71.59% 71.61% +0.02%
==========================================
Files 94 94
Lines 6449 6454 +5
Branches 739 739
==========================================
+ Hits 4617 4622 +5
Misses 1756 1756
Partials 76 76
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
bkmartinjr
reviewed
Feb 9, 2022
| raise DatasetAccessError(f"Data matrix in {self.data.X.dtype} format is not supported in backed mode." | ||
| " Please reload without --backed, or convert matrix to float32") | ||
| warnings.warn( | ||
| f"Anndata data matrix is in unsupported {self.data.X.dtype} format so will be recast to float32" |
There was a problem hiding this comment.
Nit: suggest grammatical improvement to message eg,
Anndata data matrix is in unsupported {self.data.X.dtype} format -- will be cast to float32.
bkmartinjr
approved these changes
Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert to float32 on startup unless backed, in which case error.
scipy does not support complex slicing from float16 data so this is the easiest fix for now.
Reviewers
Functional:
Readability:
Changes