Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
There is an annoying fact about Github Actions - sometimes it runs actions twice. For example:
Running a workflow twice does not make any sense, it just takes twice the time without any useful side effect.
In this PR I've added a separated job of checking if another copy of workflow already started: https://github.com/fkirc/skip-duplicate-actions
This job allows to:
Also I've found another quite annoying bug - step
actions/cache
does not update cache item if it was restored using a primary key.For example, some dependencies like dialyzer or other ones store their files in
deps
or_build
folders (which are cached in the workflow). But when these dependencies perform some updates of these folders, it does not lead to the updating ofmix.lock
file. File hasn't been changed -> hash is the same -> cache primary key is the same -> caching action will not update the existing cache.This will cause the increase of workflow run time because the stored cache will not be used by some steps. Until
mix.lock
will be updated which will lead to updating the cache item.Here I've appended a commit SHA to the cache primary key, so it will always be updated. But it will not affect cache reading.
What do you think about that?