Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed draft GitHub PR is considered as "Draft" #993

Closed
mochja opened this issue Nov 22, 2022 · 1 comment · Fixed by #997
Closed

Closed draft GitHub PR is considered as "Draft" #993

mochja opened this issue Nov 22, 2022 · 1 comment · Fixed by #997
Assignees
@morucci

Comments

@mochja
Copy link

mochja commented Nov 22, 2022 •
edited
Loading

I'd expect closed Draft PR to be reported as "Abadoned" in the UI. Currently it reports as "Draft".

image

Change timeline shows that it was abandoned and commented as I have used "Close with Comment" functionality of GH.

image
@morucci
Copy link
Collaborator

morucci commented Nov 23, 2022

Hi Ján,

Thanks for the report. That seems to be a bug indeed.
I'll provide a fix shortly.

@morucci morucci self-assigned this Nov 23, 2022
morucci added a commit to morucci/monocle that referenced this issue Nov 24, 2022
@morucci
[web] Fix state display for draft changes
98d8b57 
A draft change is only displayed as draft when the change is open.

This fix change-metrics#993
@morucci morucci mentioned this issue Nov 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@morucci morucci

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[web] Fix state display for draft changes morucci/monocle
2 participants
@morucci @mochja